element-ios icon indicating copy to clipboard operation
element-ios copied to clipboard

Delete unsend messages, not working for failed messages. showing the unsend message delete/retry button for ever.

Open toshanmugaraj opened this issue 3 years ago • 3 comments

Pull Request Checklist

  • [x] I read the contributing guide
  • [x] UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • [x] Accessibility has been taken into account.
  • [x] Pull request is based on the develop branch
  • [x] Pull request contains a changelog file in ./changelog.d
  • [x] You've made a self review of your PR
  • [x] Pull request includes screenshots or videos of UI changes
  • [x] Pull request includes a sign off

toshanmugaraj avatar Jun 23 '22 08:06 toshanmugaraj

Hi @toshanmugaraj thanks for opening this PR. Please would you be able to provide a bit of context about the bug that this fixes (and how to reproduce it) for me to review the code? Also, we'll need a changelog file in ./changelog.d and a sign off in order to be able to merge this.

pixlwave avatar Jun 23 '22 13:06 pixlwave

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@835cdda). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #6334   +/-   ##
==========================================
  Coverage           ?    6.17%           
==========================================
  Files              ?     1440           
  Lines              ?   155102           
  Branches           ?    62360           
==========================================
  Hits               ?     9585           
  Misses             ?   145113           
  Partials           ?      404           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 835cdda...e340a57. Read the comment docs.

codecov-commenter avatar Jun 26 '22 09:06 codecov-commenter

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 25 '24 11:09 CLAassistant