element-desktop icon indicating copy to clipboard operation
element-desktop copied to clipboard

Add monochrome tray icon

Open SakiiCode opened this issue 1 year ago • 9 comments
trafficstars

This PR adds a white tray icon that would be important on Linux to better fit the other icons. It can be enabled/disabled with a checkbox item in the context menu. Uses the electron store to save user preference.

Resolves #757

Signed-off-by: Sakii <[email protected]>

Checklist

  • [x] Ensure your code works with manual testing.
  • [x] New or updated public/exported symbols have accurate TSDoc documentation.
  • [x] Linter and other CI checks pass.
  • [x] Sign-off given on the changes (see CONTRIBUTING.md).

SakiiCode avatar Jul 25 '24 09:07 SakiiCode

This needs design review and I think a UI preference flag rather than a context menu option

t3chguy avatar Jul 25 '24 09:07 t3chguy

This needs design review and I think a UI preference flag rather than a context menu option

I need more info / context in order to review this... Are we just talking about showing a white/monochrome Element logo in the MacOS system bar at the top of the screen when in dark mode?

As for the logo itself, I think maybe @JordanConnor would be more knowledgeable about the intended appearance of the logo?

americanrefugee avatar Aug 05 '24 11:08 americanrefugee

@americanrefugee I believe it is predominantly for Linux where it seems to be quite common for apps to have monochrome logos

t3chguy avatar Aug 05 '24 12:08 t3chguy

Is the icon displayed within a specific shape? We prefer to include the roundel in the icon were possible (svg example)

JordanConnor avatar Aug 14 '24 11:08 JordanConnor

That'll depend on exactly what flavour of Linux you are running

t3chguy avatar Aug 14 '24 12:08 t3chguy

I cannot attach screenshots to posts for some reason but you can find them here: https://imgur.com/a/monochrome-element-screenshots-rkxoIZc

I think a UI preference flag rather than a context menu option

That may be the most fancy solution, however this is purely electron-related and involving element-web would make the implementation unnecessarily complex if it's even possible

SakiiCode avatar Aug 14 '24 13:08 SakiiCode

@SakiiCode we already have other Electron-only prefs exposed in the UI preferences

image

t3chguy avatar Aug 14 '24 13:08 t3chguy

@SakiiCode, thanks for the screenshots, yes at that scale it does feel somewhat bulky. But for consistency we may still want the roundel included, like Steam does for example Screenshot 2024-08-14 at 14 42 19

JordanConnor avatar Aug 14 '24 13:08 JordanConnor

Thanks for the feedback, I'll rework this PR

SakiiCode avatar Aug 14 '24 15:08 SakiiCode

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 09 '24 12:09 CLAassistant

@t3chguy This PR should be ready ~~but I can't seem to be able to create a PR for matrix-react-sdk. The UI preference option is in SakiiCode/matrix-react-sdk/trayicons~~ (Somehow I forked the wrong repo sorry)

SakiiCode avatar Sep 11 '24 18:09 SakiiCode

@JordanConnor Can you take a look at the new icons ? thanks!

florianduros avatar Oct 03 '24 09:10 florianduros

Icon LGTM!

JordanConnor avatar Oct 10 '24 10:10 JordanConnor

@florianduros There was one thing I could not test: after getting pinged the red dot might(?) change back the icon to the colored one. Please definitely try this before merging

SakiiCode avatar Oct 10 '24 14:10 SakiiCode

@SakiiCode Noted, thanks

Can you please sign the CLA in both PR?

florianduros avatar Oct 10 '24 14:10 florianduros