element-android icon indicating copy to clipboard operation
element-android copied to clipboard

use clipboard hack to get deferred deeplink

Open fedrunov opened this issue 2 years ago • 4 comments
trafficstars

Type of change

  • [x] Feature
  • [ ] Bugfix
  • [ ] Technical
  • [ ] Other :

Content

When a user follows a matrix.to link on mobile, it doesn't work because the app does not keep the link. Storing the link in the clipboard means it can be pasted to ensure the user reaches the room they intended to...

This is draft PR since it's blocked by

https://github.com/matrix-org/matrix.to/pull/297

Motivation and context

closes #7673

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • [ ] Physical
  • [ ] Emulator
  • OS version(s):

Checklist

  • [ ] Changes has been tested on an Android device or Android emulator with API 21
  • [ ] UI change has been tested on both light and dark themes
  • [ ] Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
  • [ ] Pull request is based on the develop branch
  • [ ] Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
  • [ ] Pull request includes screenshots or videos if containing UI changes
  • [ ] Pull request includes a sign off
  • [ ] You've made a self review of your PR
  • [ ] If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

fedrunov avatar Dec 23 '22 12:12 fedrunov

Warnings
:warning:

Please add a changelog. See instructions here

Generated by :no_entry_sign: dangerJS against 2dc103f7ee5c04cec9bb171d57279b44d2fcca7b

ElementBot avatar Dec 23 '22 12:12 ElementBot

Warnings
:warning:

Please add a changelog. See instructions here

Generated by :no_entry_sign: dangerJS against 03be46961e6f1601cd28f2b86575e9ae6f9ae7d6

ElementBot avatar Dec 23 '22 12:12 ElementBot

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


NIkita Fedrunov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 25 '24 12:09 CLAassistant