element-android icon indicating copy to clipboard operation
element-android copied to clipboard

Don't ignore verification UI tests

Open amitkma opened this issue 3 years ago • 3 comments

Type of change

  • [ ] Feature
  • [ ] Bugfix
  • [x] Technical
  • [ ] Other :

Content

  • Verification related UI tests are ignored. So it is necessary to not ignore them and verify the behaviour.

Motivation and context

UI tests related to verification has been ignored so it was hard to verify any behavior about session verification. This PR enables them so we can confirm that the UI changes are working as expected. WRT -> https://github.com/vector-im/element-android/pull/7197

Tests

To test this PR, run this command -> :vector-app:connectedGplayDebugAndroidTest

All instrumented tests should pass.

Tested devices

  • [x] Physical
  • [x] Emulator
  • OS version(s): Android 11 and 12

Checklist

  • [ ] Changes has been tested on an Android device or Android emulator with API 21
  • [ ] UI change has been tested on both light and dark themes
  • [ ] Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
  • [x] Pull request is based on the develop branch
  • [] Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
  • [ ] Pull request includes screenshots or videos if containing UI changes
  • [ ] Pull request includes a sign off
  • [x] You've made a self review of your PR
  • [ ] If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

amitkma avatar Oct 05 '22 11:10 amitkma

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 14 '22 08:10 sonarqubecloud[bot]

@BillCarsonFr can you handle this PR please? A test is not passing.

bmarty avatar Jan 10 '23 13:01 bmarty

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Amit Kumar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 25 '24 12:09 CLAassistant