Manually including `im.dlg:android-dialer:1.2.5`

[ouchadam]

Type of change

• [ ] Feature
• [ ] Bugfix
• [ ] Technical
• [x] Other :

Content

• Moves all external modules to the library/external/ directory (jsonview, dialpad and diff_match_patch)
• Manually includes the contents of im.dlg:android-dialer:1.2.5 as a dedicated module in library/external/dialpad. It turns out the classes we use are entirely AOSP.
• Replaces AppCompat usages with stock Widgets, the build tools automatically convert these to androidx variants

Motivation and context

To allow us to avoid using the jetifier and enable Paparazzi screenshot tests within the vector module

• Avoids using appcompat
• avoids using an artifact without a source repository

Screenshots / GIFs

No UI changes!

Before	After

Tests

• Force the dial pad to be displayed via the debug settings
• Open the dial pad tab

Tested devices

• [x] Physical
• [ ] Emulator
• OS version(s): 28

[ouchadam]

will exclude lint from this module as it's not our code

[ouchadam]

@bmarty I've updated the commits to split the change from the import f923edf9f4621c0b44bf152585a13b8189108d67

[ElementBot]

	Warnings
:warning:	library/external/jsonviewer/src/main/res/layout/item_jv_base_value.xml#L7 - Possible overdraw: Root element paints background ?attr/selectableItemBackground with a theme that also paints a background (inferred theme is @android:style/Theme.Holo)
:warning:	library/external/jsonviewer/src/main/res/layout/item_jv_base_value.xml#L7 - Possible overdraw: Root element paints background ?attr/selectableItemBackground with a theme that also paints a background (inferred theme is @android:style/Theme.Holo)

Generated by :no_entry_sign: dangerJS against 2168362a8b5ff1de59de739c7b58d83a415fa8c2

[bmarty]

I need this to try to try to remove jetifier from the project. Currently on develop, using this plugin id "com.dipien.byebyejetifier" version "1.2.2" and running this command: ./gradlew canISayByeByeJetifier -Pandroid.enableJetifier=false outputs:

Execution failed for task ':canISayByeByeJetifier'.
> Could not resolve all dependencies for configuration ':vector:debugAndroidTestCompileClasspath'.
   > Could not find com.android.support:support-annotations:25.3.1.
     Required by:
         project :vector > im.dlg:android-dialer:1.2.5
   > Could not find com.android.support:appcompat-v7:25.3.1.
     Required by:
         project :vector > im.dlg:android-dialer:1.2.5
   > Could not find com.android.support:design:25.3.1.
     Required by:
         project :vector > im.dlg:android-dialer:1.2.5

[ouchadam]

FYI @bmarty @jmartinesp I've had to include appcompat as a dependency 2168362a8b5ff1de59de739c7b58d83a415fa8c2 as some tasks (like sonar) were attempting to compile all variants of the module but colorPrimary only existed if the parent app module was also compiled

[sonarqubecloud[bot]]

SonarCloud Quality Gate failed.   

3 Bugs
0 Vulnerabilities
0 Security Hotspots
16 Code Smells

0.0% Coverage
1.9% Duplication