element-android icon indicating copy to clipboard operation
element-android copied to clipboard

Add initial Sentry setup for crashes and perf tracking

Open amitkma opened this issue 3 years ago • 4 comments

Type of change

  • [ ] Feature
  • [ ] Bugfix
  • [x] Technical
  • [ ] Other :

Content

  • Integrates basic Sentry setup to monitor crashes and unhandled exceptions.

Motivation and context

Closes #7076

Tests

  • It is hard to test because you have to manually throw an exception in code to test it. Otherwise it's difficult to produce a crash 🙃.

Tested devices

  • [x] Physical
  • [x] Emulator
  • OS version(s): Android 11 and 12

Checklist

  • [ ] Changes has been tested on an Android device or Android emulator with API 21
  • [ ] UI change has been tested on both light and dark themes
  • [ ] Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
  • [x] Pull request is based on the develop branch
  • [x] Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
  • [ ] Pull request includes screenshots or videos if containing UI changes
  • [ ] Pull request includes a sign off
  • [x] You've made a self review of your PR
  • [ ] If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

amitkma avatar Sep 15 '22 13:09 amitkma

It is hard to test because you have to manually throw an exception in code to test it. Otherwise it's difficult to produce a crash 🙃.

We have a hidden feature to crash the app for this specific purpose:

  • enable developer mode
  • restart the app
  • click on the green setting button which is now displayed
  • click on the button "CRASH THE APP"

bmarty avatar Sep 16 '22 16:09 bmarty

It is hard to test because you have to manually throw an exception in code to test it. Otherwise it's difficult to produce a crash 🙃.

We have a hidden feature to crash the app for this specific purpose:

  • enable developer mode
  • restart the app
  • click on the green setting button which is now displayed
  • click on the button "CRASH THE APP"

Thank you @bmarty, I wasn't aware of it.

amitkma avatar Sep 19 '22 06:09 amitkma

Warnings
:warning:

vector/src/main/AndroidManifest.xml#L206 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion

:warning:

vector/src/main/AndroidManifest.xml#L206 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion

:warning:

vector/src/main/AndroidManifest.xml#L209 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion

:warning:

vector/src/main/AndroidManifest.xml#L209 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion

:warning:

vector/src/main/AndroidManifest.xml#L263 - Expecting android:screenOrientation="unspecified" or "fullSensor" for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices

:warning:

vector/src/main/AndroidManifest.xml#L263 - Expecting android:screenOrientation="unspecified" or "fullSensor" for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices

:warning:

vector/src/main/AndroidManifest.xml#L272 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

:warning:

vector/src/main/AndroidManifest.xml#L272 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

:warning:

vector/src/main/AndroidManifest.xml#L279 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

:warning:

vector/src/main/AndroidManifest.xml#L279 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

:warning:

vector/src/main/AndroidManifest.xml#L285 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

:warning:

vector/src/main/AndroidManifest.xml#L285 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

:warning:

vector/src/main/AndroidManifest.xml#L404 - Exported receiver does not require permission

:warning:

vector/src/main/AndroidManifest.xml#L404 - Exported receiver does not require permission

Generated by :no_entry_sign: dangerJS against d118bdfc6e46838c5e0799ae899186316ff14800

ElementBot avatar Sep 20 '22 09:09 ElementBot

Hello @amitkma once approved, as a PR submitter, please feel free to merge your PR :) Thanks!

bmarty avatar Oct 05 '22 08:10 bmarty