Modularisation - vector-app module

[ouchadam]

Type of change

• [ ] Feature
• [ ] Bugfix
• [x] Technical
• [ ] Other :

Content

Adds a top level vector-app module to act as our com.android.application entry point, this will enable further modules to be extracted which rely on the vector whilst we migrate away from the mono module

• Creates a :vector-app module to be our android.application
• Moves the VectorApplication (hilt graph app) to the app module
• Moves the UI tests out of the :vector module and into the app module as they require a real VectorApplication and graph

Motivation and context

Screenshots / GIFs

No UI changes

Tests

• Make a debug build from the project

Tested devices

• [x] Physical
• [ ] Emulator
• OS version(s): 28

[ouchadam]

Once merged build kite should also be updated https://github.com/matrix-org/pipelines/pull/202

[ouchadam]

Thanks for this work! Also is there some change to do on this file? We are manually referencing paths here, which is not ideal. But this tool is still useful...

good catch, I'll update! it might be worth revisiting in the future as this file could become quite painful to manage with more modules

[ElementBot]

	Warnings
:warning:	vector-app/src/main/AndroidManifest.xml#L7 - The attribute android:allowBackup is deprecated from Android 12 and higher and may be removed in future versions. Consider adding the attribute android:dataExtractionRules specifying an @xml resource which configures cloud backups and device transfers on Android 12 and higher.
:warning:	vector-app/src/main/AndroidManifest.xml#L7 - The attribute android:allowBackup is deprecated from Android 12 and higher and may be removed in future versions. Consider adding the attribute android:dataExtractionRules specifying an @xml resource which configures cloud backups and device transfers on Android 12 and higher.
:warning:	vector-app/src/main/res/drawable/ic_launcher_background.xml#L8 - Resource references will not work correctly in images generated for this vector icon for API < 24; check generated icon to make sure it looks acceptable
:warning:	vector-app/src/main/res/drawable/ic_launcher_background.xml#L8 - Resource references will not work correctly in images generated for this vector icon for API < 24; check generated icon to make sure it looks acceptable
:warning:	vector/src/main/AndroidManifest.xml#L220 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
:warning:	vector/src/main/AndroidManifest.xml#L220 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
:warning:	vector/src/main/AndroidManifest.xml#L223 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
:warning:	vector/src/main/AndroidManifest.xml#L223 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
:warning:	vector/src/main/AndroidManifest.xml#L277 - Expecting android:screenOrientation="unspecified" or "fullSensor" for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
:warning:	vector/src/main/AndroidManifest.xml#L277 - Expecting android:screenOrientation="unspecified" or "fullSensor" for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
:warning:	vector/src/main/AndroidManifest.xml#L286 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)
:warning:	vector/src/main/AndroidManifest.xml#L286 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)
:warning:	vector/src/main/AndroidManifest.xml#L293 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)
:warning:	vector/src/main/AndroidManifest.xml#L293 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)
:warning:	vector/src/main/AndroidManifest.xml#L299 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)
:warning:	vector/src/main/AndroidManifest.xml#L299 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)
:warning:	vector/src/main/AndroidManifest.xml#L413 - Exported receiver does not require permission
:warning:	vector/src/main/AndroidManifest.xml#L413 - Exported receiver does not require permission
:warning:	vector/src/main/java/im/vector/app/features/home/room/detail/timeline/item/MessageVoiceItem.kt#L112 - Custom view AudioWaveformView has setOnTouchListener called on it but does not override performClick
:warning:	vector/src/main/java/im/vector/app/features/home/room/detail/timeline/item/MessageVoiceItem.kt#L112 - Custom view AudioWaveformView has setOnTouchListener called on it but does not override performClick
:warning:	vector/src/main/java/im/vector/app/features/home/room/detail/timeline/item/MessageVoiceItem.kt#L112 - onTouch lambda should call View#performClick when a click is detected
:warning:	vector/src/main/java/im/vector/app/features/home/room/detail/timeline/item/MessageVoiceItem.kt#L112 - onTouch lambda should call View#performClick when a click is detected

Generated by :no_entry_sign: dangerJS against feb1a2a876fd25fbfd7c12b7181688254d980719

[sonarqubecloud[bot]]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
5 Security Hotspots
2 Code Smells

0.0% Coverage
0.0% Duplication