element-android icon indicating copy to clipboard operation
element-android copied to clipboard

Fix animated images only autoplaying sometimes

Open networkException opened this issue 3 years ago • 4 comments

Type of change

  • [ ] Feature
  • [x] Bugfix
  • [ ] Technical
  • [ ] Other:

Content

This pull request fixes autoplaying animated images only actually autoplaying in some cases as only thumbnail data would be fetched in the other cases.

It introduces a new ImageContentRenderer mode specifically for animated images with thumbnail sizing that always resolves to the actual image url just like stickers for example

The autoplaying feature was originally introduced in #6166

Motivation and context

This issue was brought up in the element-android matrix channel after release 1.4.18

Screenshots / GIFs

Before After
before after

Tests

  • Send an animated image in a public room
  • Check that the image actually autoplays instead of just showing the thumbnail

Tested devices

  • [ ] Physical
  • [x] Emulator
  • OS version(s): Android 12 x86_64, Android 5 x86_64

Checklist

  • [x] Changes has been tested on an Android device or Android emulator with API 21
  • [ ] UI change has been tested on both light and dark themes
  • [ ] Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
  • [x] Pull request is based on the develop branch
  • [x] Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
  • [x] Pull request includes screenshots or videos if containing UI changes
  • [x] Pull request includes a sign off
  • [x] You've made a self review of your PR
  • [ ] If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

networkException avatar May 31 '22 20:05 networkException

Updated to resolve the conflict with https://github.com/vector-im/element-android/commit/b3fdb5ed17d057003581bebefd64352e9c3abbd2#diff-4c7d967a761a61ec885422f0b073f89bfc930e8ba67e825af801a1ed6a28c9d5L272

networkException avatar Jun 15 '22 14:06 networkException

Is there anything blocking this from getting merged?

networkException avatar Jul 26 '22 12:07 networkException

Is there anything blocking this from getting merged?

Came here to ask this as well. Would love for this to be merged!

ryanpeters-MSFT avatar Jul 26 '22 16:07 ryanpeters-MSFT

@bmarty is there something missing for this to get merged?

networkException avatar Sep 21 '22 19:09 networkException

@bmarty is there something missing for this to get merged?

Just time. Thanks for the update!

bmarty avatar Oct 04 '22 15:10 bmarty