Don't mark room as unread due to reactions

[ofalvai]

Type of change

• [ ] Feature
• [X] Bugfix
• [ ] Technical
• [ ] Other :

Content

Fixes #2907

Motivation and context

I found it distracting and frustrating that my room list had a lot of unread indicators, showing unread reactions by other people. This is especially distracting in read-only announcement rooms where reactions are often added to old messages.

This change also aligns Element Android to Element Web in handling reactions.

Screenshots / GIFs

Before	After

Tests

Manual testing with my own unread channels

Tested devices

• [X] Physical
• [ ] Emulator
• OS version(s): Android 11

Checklist

• [ ] Changes has been tested on an Android device or Android emulator with API 21
• [ ] UI change has been tested on both light and dark themes
• [X] Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• [X] Pull request is based on the develop branch
• [X] Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• [X] Pull request includes screenshots or videos if containing UI changes
• [X] Pull request includes a sign off
• [X] You've made a self review of your PR
• [ ] If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

Signed-off-by: Olivér Falvai [email protected]

[ouchadam]

looping in product to confirm the behaviour

• Reactions will no longer mark rooms as unread
• Reactions will no longer show as the last message in room list

[ofalvai]

Just a friendly ping to make sure it's not forgotten.

If it's okay from the product POV, I'll rebase this PR and resolve conflicts.

[daniellekirkwood]

🎙 Product

The Web product has a setting that changes whether the reaction shows up in the message preview - is that something we have here?

Otherwise, looks good. Glad that we're matching Web!

[ofalvai]

@daniellekirkwood this change simply disables the unread reactions (as shown on the screenshots). But if you say a new setting is required for this, I'm happy to include that.

Just to clarify: in the web product this is under Labs and it's disabled by default (meaning that this PR will change the default behavior).

[daniellekirkwood]

Good to know, thanks!

[bmarty]

@ofalvai can I ask you to handle https://github.com/vector-im/element-android/pull/5846#discussion_r1065824274? Then we could merge this PR. Thanks!

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}