rebuild icon indicating copy to clipboard operation
rebuild copied to clipboard

Sysroot downloader doesn't support electron 19+

Open zawata opened this issue 3 years ago • 1 comments

Was experimenting with switching from our homemade native module rebuilder system to electron-rebuild when I ran into an issue: image

The line of code that's failing: https://github.com/electron/rebuild/blob/a328ed2251fe23d8beec1b2df5f1726dffc65759/src/sysroot-fetcher.ts#L28 fails because starting with electron 19, the sysroots are debian bullseye, not debian sid: https://github.com/electron/electron/blob/59dd17f2cf0c816a718336d03667e42ca81ca187/script/sysroots.json

command: npx electron-rebuild -v 21.2.2 --use-electron-clang

versions:

  • Manjaro 22.0.0
  • node 16.17
  • electron 21.2.2
  • electron-rebuild 3.2.9

zawata avatar Nov 08 '22 22:11 zawata

Looks like this was fixed in #1046 but the version with these changes hasn't been released yet.

bencwallace avatar Jan 08 '23 17:01 bencwallace