vite-plugin-electron-renderer icon indicating copy to clipboard operation
vite-plugin-electron-renderer copied to clipboard

Fix issue with electron-store

Open pelletier197 opened this issue 1 year ago • 1 comments

This allows to use electron-store V10 inside the Renderer. Resolves #86

pelletier197 avatar Jul 15 '24 02:07 pelletier197

Hey @caoxiemeihao! Sorry for tagging you, this is a bit a random PR but I have been experiencing an issue with electron store and this solved the issue for me. Do you see any problem with this solution?

Thank you 🙏

pelletier197 avatar Jul 16 '24 23:07 pelletier197

@caoxiemeihao poke :)

Stanzilla avatar Aug 09 '24 00:08 Stanzilla

@pelletier197 ah if we also add BrowserWindow, would that fix https://github.com/electron-vite/vite-plugin-electron-renderer/issues/88 as well?

Stanzilla avatar Aug 10 '24 00:08 Stanzilla

Good question. Maybe, but i'm not sure BrowserWindow is supposed to be exposed in the renderer process. Maybe @caoxiemeihao would know ?

pelletier197 avatar Aug 23 '24 13:08 pelletier197

@Stanzilla @pelletier197 Sorry! I've been busy lately and I noticed this problem. Perhaps we can list the modules exported by the Main process more completely. This will be more compatible.

Also, could you change the target branch to v0.14.6? This will be the next release.

caoxiemeihao avatar Sep 19 '24 12:09 caoxiemeihao