electron-userland
Fix support for snapcraft core22 and core24
As of now it's possible to build for core22 but it uses the wrong plugs. The latest core24 is not properly supported.
Adding proper support for both would require different plugs setup on the snapcraft.yaml as well as likely workarounds depending on version, e.g. different extensions.
See https://snapcraft.io/docs/gnome-3-34-extension and https://snapcraft.io/docs/gnome-extension
Side-note: Currently, the default plugs are also not the proper ones if we account for using Ubuntu 20 as base (
core20), So it's also probably worth to look into it. Related to https://github.com/electron-userland/electron-builder/pull/6976#issuecomment-1446363261
I'm preparing a PR to attempt to tackle this issue.
Similar PRs: https://github.com/electron-userland/electron-builder/pull/7320 , https://github.com/electron-userland/electron-builder/pull/7378
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.
This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment, or this will be closed in 30 days.
This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment, or this will be closed in 30 days.
This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment, or this will be closed in 30 days.
I think that using the correct gnome extension for core22 and core24 would also fix #5217
This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment, or this will be closed in 30 days.
I think this is blocking me from upgrading to electron 38, but it might just be me. The build does seem to require core24 as it has a new structure, but using the core22 results in a different structure that then the snap file doesn't understand. Is there a plan to implement this? Thanks
I have core24 on my todo list. The limitation with the current implementation is that it leverages the upstream Go dep app-builder for snap.
To avoid regressions, I plan to solely implement core24-support, within completely in electron-builder/JS.
Any helper or pointers on changes occurred/needed for core24 would be greatly appreciated. Otherwise, I'll just be learning this as I go.
It was a while back but my issue was regarding the structure (I seem to recall), but only failed on the binary execution/start-up, not on installation.
Unfortunately the only issue that the electron did report was a Segmentation fault (core dumped) . Hope helps!