electron-userland
feat: use electron-winstaller instead of self module
- support window arm
- fix bugs(https://github.com/Squirrel/Squirrel.Windows/releases)
🦋 Changeset detected
Latest commit: 11f53eeec695d8b17c289aca43adaac641d012ea
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
| Name | Type |
|---|---|
| app-builder-lib | Patch |
| electron-builder-squirrel-windows | Patch |
| dmg-builder | Patch |
| electron-builder | Patch |
| electron-forge-maker-appimage | Patch |
| electron-forge-maker-nsis-web | Patch |
| electron-forge-maker-nsis | Patch |
| electron-forge-maker-snap | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
Is this package actually still supported by the electron team? Many packages in that org have been dead for a long time.
Is this package actually still supported by the electron team? Many packages in that org have been dead for a long time.
That's a great point. @beyondkmp what bug fixes is this solving for? (Can't tell from the description)
@Stanzilla looks like updates are still being pushed to electron-winstaller, last update was 3mo ago. https://www.npmjs.com/package/electron-winstaller
Is this package actually still supported by the electron team? Many packages in that org have been dead for a long time.
That's a great point. @beyondkmp what bug fixes is this solving for? (Can't tell from the description)
It's a bit much; we can get it from the release page(https://github.com/Squirrel/Squirrel.Windows/releases).
However, what I want most is to update to the latest commit to include this fix: https://github.com/Squirrel/Squirrel.Windows/pull/1862. My plan is to first update to version 2.0.1. If there are no issues, then update to the latest.
This https://github.com/electron/windows-installer is being updated, but some updates are not timely, and some executable files are almost 10 years old. I have identified two issues and submitted PRs for them.
https://github.com/electron/windows-installer/pull/524 https://github.com/electron/windows-installer/pull/525
Currently, I have forked the repository and published electron-squirrel-winstaller to npm. I want to update this library more quickly, and I will start using the electron-squirrel-winstaller library in our company's app production.
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@mmaietta Resolved the code conflict now, but this UT keeps failing, running locally is no problem. It looks like there is a problem with this UT on the master, help me out if you have time.
I'll take a look at this today. There is no problem on master though...as the commit test history is clean: https://github.com/electron-userland/electron-builder/commits/master/
I pushed your branch to origin/win-installer within the electron-builder repo and the tests all pass correctly: https://github.com/electron-userland/electron-builder/actions/runs/13076539224
My best guess is that running the job from your fork is not able to access that repo secret specifically?
@mmaietta Yes, that's correct. The reason is the same as what you mentioned. The conflicts in this MR have been resolved. When you have time, please help review it again. If there are no issues, it can be merged.