electron-builder icon indicating copy to clipboard operation
electron-builder copied to clipboard

fix: github private repo differential updates

Open NGrey5 opened this issue 4 years ago • 9 comments

Following the issues discussed in #6184

NGrey5 avatar Aug 27 '21 19:08 NGrey5

🦋 Changeset detected

Latest commit: 34624b4893d2a9401e4639c3c61a14715cb69398

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 27 '21 19:08 changeset-bot[bot]

If anyone wants to try and help figure out the checksum issue; I would appreciate it!

I haven't been able to figure out anything that solves it.

NGrey5 avatar Oct 01 '21 17:10 NGrey5

I have developed a better delta update mechanism based on binary diffing for the NSIS target. It's being deployed in production with thousands of users and running smoothly.

The delta update mechanism based on the blockmap approach uses a very good amount of bandwidth. The binary diffing approach works better and downloads only the diff, generally less than 1MB to update the app.

sandeep1995 avatar Oct 27 '21 14:10 sandeep1995

@sandeep1995 would you be willing to contribute that logic to electron-builder? Or share the logic via gist or sample electron-quick-start repo?

mmaietta avatar Nov 09 '21 18:11 mmaietta

I don't understand why the private repo SHA512 can't match. Maybe there is a problem with the latest file and blockmap file in the process of building

YouLiLiao avatar Jan 21 '22 09:01 YouLiLiao

@NGrey5 Were you able to figure out the solution for private GitHub repos?

Supriy-codeBreaker avatar Jan 29 '22 09:01 Supriy-codeBreaker

@Supriy-codeBreaker I haven't made any further progress on this due to the checksum mismatch error. I'm awaiting someone with a little more knowledge of this to possibly help out.

NGrey5 avatar Jan 31 '22 15:01 NGrey5

As I mentioned earlier here https://github.com/electron-userland/electron-builder/pull/6198#issuecomment-952963668

If you guys are looking for a true delta builder and updater, please checkout https://github.com/electron-delta/electron-delta and https://electrondelta.com/

sandeep1995 avatar Apr 26 '22 21:04 sandeep1995

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Sep 21 '22 04:09 stale[bot]