Elco Jacobs

Results 35 comments of Elco Jacobs
trafficstars

I now have test passing and binary size not increased much with the latest version: https://github.com/BrewBlox/brewblox-firmware/pull/158/files It required quite a few changes, mainly casting the result returned by cnl::quotient to...

I am casting the result, because specifying the desired type as a template parameter gives unexpected results when the precision is increased. Is this a bug or am I doing...

That is what I thought, I don't think this issue is with overflow, but with elastic integer. It doesn't make sense that it can go beyond its numeric_limits lowest and...

When the outer type that scaled_integer wraps is an overflow integer, the value is clipped. But without 128 bit support, it doesn't compile. I cannot find a combination with the...

I'm avoiding wide_integer because of the extra costs involved, that's why I am not using static_number. Decreasing the number of bits is an option, but there are other errors with...

Looking at the template error trace, the error comes from the multiply operator, could this be happening? - The result of t1+t2 is 38 bits, so it instantiates this larger...

Actually, I spoke too soon, sorry. The tests seems to be just as fast with your suggested introduction of wide_integer. I needed to fix one test though: ``` cpp using...

I don't get a compile error when I switch the type to native rounding. The error seems to start from the divide op in nearest_rounding.

FYI, I completely removed the rounding_integer and added some manual rounding when converting to integer types where it was required. I'm now ready to switch to the current version of...

Test build is failing because no stubs for esp_eth exist in mock-idf. I can add some empty functions, but not sure if that's the right approach. The mocks here are...