logstash icon indicating copy to clipboard operation
logstash copied to clipboard

Reimplemented LogStash::String setting in Java

Open andsel opened this issue 1 year ago • 2 comments

Release notes

What does this PR do?

Why is it important/What is the impact to the user?

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ] Implements the other constructors, with 2 and 3 params and spread the use
    • [ ] Execute SPEC_OPTS="-fd -f logstash-core/spec/logstash/runner_spec.rb" ./gradlew --rerun-tasks :logstash-core:rubyTests there is a problem in reading the deprecation logger messages in https://github.com/elastic/logstash/blob/467ab3f44b6f0c2b09f6c39b7a5f90727e761485/logstash-core/spec/logstash/runner_spec.rb#L269. Suggestion mock the Appender and reconfigure logs?
  • [ ] Check the code for other instantiations of LogStash::String.new
  • [ ] Translate RSpec tests to JUnit if there are or cover with some testing
  • [ ] Rename StringSetting to String and use explicit java.lang.String around

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

andsel avatar Oct 17 '24 09:10 andsel

:green_heart: Build Succeeded

History

  • :green_heart: Build #2124 succeeded 6380a323a129107eb63f44c41fcc0c9502cb25fb
  • :green_heart: Build #2086 succeeded 605459c53a5e73a4282b76df14e2d3b7bda0d0d9
  • :broken_heart: Build #2085 failed 187af42317d13642f27cc4d4fc36482a6586227b
  • :green_heart: Build #1846 succeeded dcae6f5c9d64d4aaaa531bdcf3aaf37b5e381f91
  • :broken_heart: Build #1842 failed 180d5975ef1640a8911638f5e1f85c67addc61ee
  • :yellow_heart: Build #1841 was flaky 91e2048b7b6ddf8bed48439b973be9630735d96a

cc @andsel

elasticmachine avatar Jan 24 '25 15:01 elasticmachine

@logstashmachine backport 8.17

andsel avatar Jan 24 '25 15:01 andsel

@logstashmachine backport 8.16

andsel avatar Jan 24 '25 15:01 andsel

8.17: ~~https://github.com/elastic/logstash/pull/16947~~ https://github.com/elastic/logstash/pull/16960 8.16: ~~https://github.com/elastic/logstash/pull/16948~~ https://github.com/elastic/logstash/pull/16961

andsel avatar Jan 24 '25 16:01 andsel

@andsel please also backport to 8.x

kaisecheng avatar Jan 24 '25 18:01 kaisecheng

@logstashmachine backport 8.x

andsel avatar Jan 27 '25 08:01 andsel

8.x backport https://github.com/elastic/logstash/pull/16959

andsel avatar Jan 27 '25 14:01 andsel