logstash
logstash copied to clipboard
Reimplemented LogStash::String setting in Java
Release notes
What does this PR do?
Why is it important/What is the impact to the user?
Checklist
- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
- [ ] I have added tests that prove my fix is effective or that my feature works
Author's Checklist
- [ ] Implements the other constructors, with 2 and 3 params and spread the use
- [ ] Execute
SPEC_OPTS="-fd -f logstash-core/spec/logstash/runner_spec.rb" ./gradlew --rerun-tasks :logstash-core:rubyTeststhere is a problem in reading the deprecation logger messages in https://github.com/elastic/logstash/blob/467ab3f44b6f0c2b09f6c39b7a5f90727e761485/logstash-core/spec/logstash/runner_spec.rb#L269. Suggestion mock theAppenderand reconfigure logs?
- [ ] Execute
- [ ] Check the code for other instantiations of
LogStash::String.new - [ ] Translate RSpec tests to JUnit if there are or cover with some testing
- [ ] Rename
StringSettingtoStringand use explicitjava.lang.Stringaround
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
Quality Gate passed
Issues
0 New issues
0 Fixed issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Quality Gate passed
Issues
0 New issues
0 Fixed issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
:green_heart: Build Succeeded
- Buildkite Build
- Commit: c212855e1933ab1a5e57a95a55193e0bbc83c894
History
- :green_heart: Build #2124 succeeded 6380a323a129107eb63f44c41fcc0c9502cb25fb
- :green_heart: Build #2086 succeeded 605459c53a5e73a4282b76df14e2d3b7bda0d0d9
- :broken_heart: Build #2085 failed 187af42317d13642f27cc4d4fc36482a6586227b
- :green_heart: Build #1846 succeeded dcae6f5c9d64d4aaaa531bdcf3aaf37b5e381f91
- :broken_heart: Build #1842 failed 180d5975ef1640a8911638f5e1f85c67addc61ee
- :yellow_heart: Build #1841 was flaky 91e2048b7b6ddf8bed48439b973be9630735d96a
cc @andsel
@logstashmachine backport 8.17
@logstashmachine backport 8.16
8.17: ~~https://github.com/elastic/logstash/pull/16947~~ https://github.com/elastic/logstash/pull/16960 8.16: ~~https://github.com/elastic/logstash/pull/16948~~ https://github.com/elastic/logstash/pull/16961
@andsel please also backport to 8.x
@logstashmachine backport 8.x
8.x backport https://github.com/elastic/logstash/pull/16959