logstash icon indicating copy to clipboard operation
logstash copied to clipboard

Remove obsolete code to download JDK from Adoptium website

Open andsel opened this issue 1 year ago • 2 comments

Release notes

[rn:skip]

What does this PR do?

Remove the dead code to download JDK binaries from the Adoptium website. Updates also the versions.yml to reflect this change and permit the selection of just major number of a JDK, the full version is extracted from Elastic's JDK registry.

Why is it important/What is the impact to the user?

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have commented my code, particularly in hard-to-understand areas
  • ~~[ ] I have made corresponding changes to the documentation~~
  • ~~[ ] I have made corresponding change to the default configuration files (and/or docker env variables)~~
  • ~~[ ] I have added tests that prove my fix is effective or that my feature works~~

Author's Checklist

  • [x] tested locally

How to test this PR locally

Run the command:

./gradlew clean downloadJdk -Pjdk_bundle_os=darwin -Pjdk_arch=arm64

Related issues

  • Closes #16344

Logs

(main) % ./gradlew clean downloadJdk -Pjdk_bundle_os=darwin -Pjdk_arch=arm64
To honour the JVM settings for this build a single-use Daemon process will be forked. For more on this, please refer to https://docs.gradle.org/8.7/userguide/gradle_daemon.html#sec:disabling_the_daemon in the Gradle documentation.
Daemon will be stopped at the end of the build
Retrieving JDK 21 from catalog...
Retrieved! Download path: /jvm-catalog.elastic.co/adoptiumjdk-21.0.4_7-darwin-aarch64.tar.gz

andsel avatar Aug 20 '24 14:08 andsel

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

elastic-sonarqube[bot] avatar Aug 20 '24 14:08 elastic-sonarqube[bot]

:green_heart: Build Succeeded

cc @andsel

elasticmachine avatar Aug 20 '24 14:08 elasticmachine