kibana icon indicating copy to clipboard operation
kibana copied to clipboard

[Metrics UI] Show toast errors when requests fail

Open neptunian opened this issue 4 years ago • 3 comments

Extending https://github.com/elastic/kibana/pull/96871, move the toast from useHttpRequest to useTrackedPromise so it shows up whenever a request fails. We should retain the option to pass in a type of toast (eg. warning instead of danger) that useHttpRequest has. Should probably pass in a string like warning | danger so we don't import everywhere.

There will be the error toast anytime a promise is rejected:

Screen Shot 2021-04-13 at 11 01 24 AM

Currently there is no notification that something went wrong in some requests: Screen Shot 2021-04-13 at 11 11 48 AM

Be sure to test and create issues to fix requests that are not handling rejections properly or there are errors being surfaced with the toast we are not aware of. Sometimes we may not want a toast to show up, so consider adding a flag for that if it can't be handled better. Screen Shot 2021-04-14 at 10 05 37 AM Improving the error handling of the requests is probably out of the scope of this issue and could be done in follow up PRs

neptunian avatar Apr 14 '21 14:04 neptunian

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

elasticmachine avatar Apr 14 '21 14:04 elasticmachine

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

elasticmachine avatar Nov 14 '23 00:11 elasticmachine

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

botelastic[bot] avatar May 12 '24 00:05 botelastic[bot]

We're not prioritizing this at this time.

smith avatar May 18 '24 03:05 smith