kibana
kibana copied to clipboard
elastic
Search source flatten refactor more
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] Flaky Test Runner was used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
- [ ] This was checked for cross-browser compatibility
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
| Risk | Probability | Severity | Mitigation/Notes |
|---|---|---|---|
| Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. |
| Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. |
| See more potential risk examples |
For maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately
@lukasolson I agree it would be great to improve the types. My earlier attempts didn't go well but it might be easier at this point
I wonder if this is all extraneous and could just be replaced with
That doesn't work, at least not when I run the corresponding search_source.test.ts jest tests.
That doesn't work, at least not when I run the corresponding search_source.test.ts jest tests.
This seems to work:
// only include unique values
if (sourceFieldsProvided && !isEqual(remainingFields, fieldsFromSource)) {
body._source = { includes: remainingFields };
}
I took a stab at improving the types here: https://github.com/mattkime/kibana/pull/21
:green_heart: Build Succeeded
- Buildkite Build
- Commit: 51976d7f557591a0c7249f2ed02c650cd9f54d70
- Kibana Serverless Image:
docker.elastic.co/kibana-ci/kibana-serverless:pr-183206-51976d7f5575 - Observability Deployment
Metrics [docs]
Canvas Sharable Runtime
The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.
| id | before | after | diff |
|---|---|---|---|
module count |
- | 5412 | +5412 |
total size |
- | 8.8MB | +8.8MB |
Page load bundle
Size of the bundles that are downloaded on every page load. Target size is below 100kb
| id | before | after | diff |
|---|---|---|---|
data |
419.0KB | 419.0KB | -2.0B |
dataViews |
61.6KB | 61.7KB | +123.0B |
| total | +121.0B |
History
- :yellow_heart: Build #212234 was flaky 2395f2aaeb6db93e68ddc3b1a045e875a721232e
- :broken_heart: Build #212219 failed 815cc33dab5c1b9926b45f0b1a356624be27e4df
- :broken_heart: Build #212218 failed 815cc33dab5c1b9926b45f0b1a356624be27e4df
- :broken_heart: Build #211337 failed f08d31ab11087a5b609f79bacfc585bcbf95550e
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
cc @mattkime
Closing as a managed to mangle this branch with a bad force push. This PR has all the content - https://github.com/elastic/kibana/pull/184282 but I'm going to try to get a smaller subset merged first https://github.com/elastic/kibana/pull/184286