kibana
kibana copied to clipboard
elastic
[Embeddables Rebuild] Migrate Visualize
Summary
Closes #174958
This migrates the Visualize embeddable to the new React Embeddable framework.
Migrated:
- Edit visualization action
- Convert to lens action
- Extracting/injecting references on serialize and deserialize
- Inspector adapters
- Dashboard settings
- Drilldown support
- Timeslice/time slider support
- Custom time ranges
Also adds deprecation statements to legacy Embeddable factories
In a second PR, we'll move the embeddable folder to legacy/embeddable and rename react_embeddable to embeddable. I don't know if git will be able to diff that change in a comprehensible way in this PR, so I want to save it for the next one.
Checklist
- [x] Unit or functional tests were updated or added to match the most common scenarios
:robot: GitHub comments
Expand to view the GitHub comments
Just comment with:
/oblt-deploy: Deploy a Kibana instance using the Observability test environments.rundocs-build: Re-trigger the docs validation. (use unformatted text in the comment!)
Making notes here of what still remains to be done:
- [ ]
uiStateneeds to be properly passed into the DefaultEditor component - [ ] ~Area aggregations are throwing errors in the
xyChartcomponent, need to figure out why this is~ This has stopped happening?? - [ ] PDF rendering still breaks a lot of CI tests
- [ ] Visualizations added using Add To Library need to open the Saved Object editor (
visualize_editor.tsx), not the By Value editor - [ ] By Value editor works for loading visualizations, but index pattern data isn't getting saved properly causing them to error out on the dashboard
Status report on tile types:
Fully migrated
- Text markdown
- TSVB
- Tag cloud
- Line
- Data table
- Vertical bar
- Horizontal bar
- Pie
- Timelion
Failing on UI State error
- Gauge
- Goal
- Metric
- Heat map
Continuing to fix bugs, some existing, some from changes introduced from main. Known issues at the moment:
- [x] TSVB visualizations fail to save to library
- [x] Saving a vis from visualize and adding it to an existing dashboard doesn't transfer it to the dashboard correctly
- [x] Creating a TSVB panel from the dashboard doesn't transfer it to the dashboard
- [x] Saved searches don't save
- [x] Cannot break link to saved search from visualize editor sidebar
Known issues from latest merge:
- [x] Add from library doesn't load the vis title
- [x] Save to library breaks saved search
- [x] Save TSVB to library and add to dashboard fails to redirect and add to dashboard
A lot of test failures are related to the app state not storing properly in the URL. This might be a fairly involved refactor, I'll try to make it minimally invasive.