kibana
kibana copied to clipboard
Update Storybook to 6.5
Summary
As titled. I'm working on some documentation upgrades for Shared UX, and would like to use MDX-2 and interaction functionality.
- [x] Pinned
coloretteto avoid ayarninstall issue when bootstrapping. - [x] Followed and applied migration guidance.
- [x] Removed incorrect addon from Discover, (addon does not exist)
- [x] Tested each Storybook for startup compatibility.
- [x] Tested Canvas addon.
Pinging @elastic/kibana-operations (Team:Operations)
Pinging @elastic/apm-ui (Team:apm)
Had a chat with the Storybook team, wrote a PR to address the type check problem. Fix from them pending, and then we'll be clear to ship this.
https://github.com/storybookjs/storybook/pull/19048
@clintandrewhall Thank you for updating storybook! would you mind bumping to the newest version ^6.5.12? as it fixes some compatibility issues with React@18?
@patrykkopycinski Sure thing!
@elasticmachine test this
:green_heart: Build Succeeded
- Buildkite Build
- Commit: a694e71d72b1a09386fc8b4c681080b0938378fb
- Storybooks Preview
Metrics [docs]
Module Count
Fewer modules leads to a faster build time
| id | before | after | diff |
|---|---|---|---|
apm |
1314 | 1346 | +32 |
canvas |
1152 | 1163 | +11 |
controls |
202 | 207 | +5 |
crossClusterReplication |
139 | 146 | +7 |
dashboard |
394 | 401 | +7 |
enterpriseSearch |
1714 | 1746 | +32 |
fileUpload |
206 | 309 | +103 |
graph |
285 | 294 | +9 |
indexManagement |
485 | 492 | +7 |
infra |
1007 | 1017 | +10 |
ingestPipelines |
327 | 352 | +25 |
lens |
905 | 912 | +7 |
licenseManagement |
130 | 137 | +7 |
maps |
990 | 1019 | +29 |
ml |
1622 | 1626 | +4 |
monitoring |
508 | 518 | +10 |
observability |
467 | 477 | +10 |
presentationUtil |
186 | 193 | +7 |
remoteClusters |
122 | 129 | +7 |
rollup |
143 | 150 | +7 |
securitySolution |
3149 | 3166 | +17 |
synthetics |
992 | 1011 | +19 |
threatIntelligence |
205 | 210 | +5 |
timelines |
256 | 273 | +17 |
| total | +394 |
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
| id | before | after | diff |
|---|---|---|---|
apm |
3.1MB | 3.1MB | +14.5KB |
canvas |
1.0MB | 1.0MB | +3.5KB |
controls |
458.6KB | 460.2KB | +1.6KB |
crossClusterReplication |
165.5KB | 167.9KB | +2.4KB |
dashboard |
387.5KB | 390.0KB | +2.5KB |
enterpriseSearch |
1.7MB | 1.7MB | +8.3KB |
fileUpload |
851.2KB | 907.0KB | +55.7KB |
graph |
450.6KB | 453.7KB | +3.0KB |
home |
147.0KB | 147.8KB | +760.0B |
indexManagement |
523.0KB | 525.4KB | +2.4KB |
infra |
1.0MB | 1.0MB | +2.8KB |
ingestPipelines |
430.8KB | 436.8KB | +6.0KB |
lens |
1.2MB | 1.2MB | +2.4KB |
licenseManagement |
63.4KB | 65.8KB | +2.4KB |
maps |
2.6MB | 2.7MB | +14.2KB |
ml |
3.4MB | 3.4MB | +1.0KB |
monitoring |
479.7KB | 482.6KB | +2.8KB |
observability |
522.5KB | 525.4KB | +2.8KB |
presentationUtil |
130.5KB | 132.9KB | +2.4KB |
remoteClusters |
84.1KB | 86.5KB | +2.4KB |
rollup |
131.2KB | 133.6KB | +2.4KB |
securitySolution |
6.6MB | 6.6MB | +2.9KB |
synthetics |
1021.3KB | 1.0MB | +5.9KB |
threatIntelligence |
74.6KB | 74.7KB | +49.0B |
| total | +145.2KB |
Page load bundle
Size of the bundles that are downloaded on every page load. Target size is below 100kb
| id | before | after | diff |
|---|---|---|---|
kbnUiSharedDeps-npmDll |
5.0MB | 5.0MB | +5.2KB |
securitySolution |
263.5KB | 265.9KB | +2.4KB |
threatIntelligence |
28.7KB | 30.3KB | +1.6KB |
timelines |
268.7KB | 274.0KB | +5.2KB |
| total | +14.4KB |
Unknown metric groups
API count
| id | before | after | diff |
|---|---|---|---|
@kbn/storybook |
38 | 41 | +3 |
Unreferenced deprecated APIs
| id | before | after | diff |
|---|---|---|---|
@kbn/storybook |
0 | 1 | +1 |
History
- :broken_heart: Build #75055 failed 84a4e734ef0838e5a1b57b4c50dd48e23692a5e2
- :broken_heart: Build #74963 failed b3f4fb7aec77e0c8428086499e06c74b2d9beb08
- :green_heart: Build #74690 succeeded d50d1b7425b7ebbe30640d11b3b752ccb54894bd
- :green_heart: Build #74530 succeeded 9706055aefdc1f5129615e3aab66e28aa9058719
- :broken_heart: Build #74513 failed 1a4e525b4b8e7e2cf3216cbd959cd1c2f6736f94
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream