eui icon indicating copy to clipboard operation
eui copied to clipboard

feat(eui): add tooltipProps prop to EuiCopy

Open weronikaolejniczak opened this issue 6 months ago • 4 comments

Summary

[!IMPORTANT] This is a breaking change.

Closes https://github.com/elastic/eui/issues/8382

On this PR, I:

Storybook

Control displays correctly:

Screenshot 2025-06-06 at 17 12 48

No VRT references difference that could be a result of the changes on this PR.

Docs impact

Button guidelines (Staging link)

Production Localhost
image image

It set anchorClassName to eui-fullWidth so that the anchor takes the whole width of the container. Otherwise, the result would be:

full width classname

Context menu (Staging link)

Production Localhost
image image

It set anchorClassName to eui-fullWidth so that the anchor takes the whole width of the container.

Icons (Staging link)

Production Localhost
image image

It set display="block" on the EuiToolTip anchor:

https://github.com/elastic/eui/blob/f319078347eaf905afb667c7492c989fdb1d581e/packages/eui/src/components/tool_tip/tool_tip.tsx#L345-L358

Kibana impact

There are 3 usages that pass props other than: textToCopy (required), beforeMessage, afterMessage

All usages | Update commit

Cloud UI impact

There are no usages that pass props other than: textToCopy (required), beforeMessage, afterMessage

All usages

QA

Specific checklist

  • [ ] The unit tests pass in CI
  • [ ] The doc pages have no regression (staging links above)
  • [ ] The EuiCopy component has no regression in Storybook (you have to run Storybook locally with: yarn workspace @elastic/eui start) or on the documentation page
  • [ ] The Kibana and Cloud UI affected usages lists are complete

General checklist

  • Browser QA
    • [ ] ~Checked in both light and dark modes~
    • [ ] ~Checked in both MacOS and Windows high contrast modes~
    • [ ] ~Checked in mobile~
    • [ ] ~Checked in Chrome, Safari, Edge, and Firefox~
    • [ ] ~Checked for accessibility including keyboard-only and screenreader modes~
  • Docs site QA
    • [ ] ~Added documentation~ (updated it)
    • [ ] ~Props have proper autodocs (using @default if default values are missing) and playground toggles~ (control for the prop, by default object)
    • [ ] ~Checked Code Sandbox works for any docs examples~
  • Code quality checklist
  • Release checklist
    • [x] A changelog entry exists and is marked appropriately.
    • [x] If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • [ ] ~If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)~

weronikaolejniczak avatar Jun 06 '25 14:06 weronikaolejniczak