eui icon indicating copy to clipboard operation
eui copied to clipboard

[EuiDataGrid] width is more than a container with customBodyRender

Open logeekal opened this issue 1 year ago • 7 comments

Describe the bug When grid has a static height and customBodyRender , the table width is more than the container which results in a horizontal scrollbar. This phenomenon is also visible in the docs page. Below i have attached a codesandbox link also.

https://github.com/user-attachments/assets/f72b2e20-fe8e-4b07-aeef-357b1b805ad5

Impact and severity

This results in degraded user experience because security solution needs to have both static height and custom body render.

One related issue is : #8002

Environment and versions

  • EUI version: 95.10.1 and older
  • React version: 17
  • Kibana version (if applicable):
  • Browser: Firefox, chrome

To Reproduce Steps to reproduce the behavior:

  1. Go to codesandbox : https://codesandbox.io/p/sandbox/custom-body-render-width-issue-svtl3t?file=%2Fdemo.tsx
  2. Switch Static height On and off and see the scrollbar appearing.
  3. See the bottom of the table and note the horizontal scrollbar.

Expected behavior When columns have auto width, table should be contained in the scrollbar.

Minimum reproducible sandbox https://codesandbox.io/p/sandbox/custom-body-render-width-issue-svtl3t?file=%2Fdemo.tsx

logeekal avatar Sep 24 '24 09:09 logeekal

@logeekal We're trying to determine priority on this - is this something you could see fixing as part of your draft PR? Or is this blocking your current work? If not I'm not sure when our team will have time to work on this, as we have several other datagrid efforts we're currently prioritizing instead.

cee-chen avatar Sep 24 '24 16:09 cee-chen

Thanks @cee-chen for pointing it out. It makes sense and I will try to get it with my currently open PR.

logeekal avatar Sep 25 '24 04:09 logeekal

Hey @logeekal, just curious, when are your changes targeted for in Kibana?

JasonStoltz avatar Sep 25 '24 18:09 JasonStoltz

Hey @JasonStoltz , apologies for late revert. I am planning mainly changes required for #8002 for 8.16. I am trying to see what is important to improve experience on that front and fix that first and if I see that this can be included. I will do that.

logeekal avatar Sep 27 '24 14:09 logeekal

@logeekal Just to confirm -- this issue is still an issue, it was not fixed as part of #8028, correct?

JasonStoltz avatar Jan 08 '25 20:01 JasonStoltz

@JasonStoltz , Yes it is correct. This was not fixed because i think it needs a bigger change.

logeekal avatar Jan 13 '25 10:01 logeekal

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

github-actions[bot] avatar Sep 22 '25 00:09 github-actions[bot]