eui icon indicating copy to clipboard operation
eui copied to clipboard

[EuiDatePicker] Fix `inline` rendering + add `append`/`prepend` support

Open cee-chen opened this issue 1 year ago • 1 comments

Summary

I discovered an inline EuiDatePicker border regression while investigating #5958, and I also discovered some very incorrect usages of EuiFormControlLayout while grepping for the component in Kibana.

Adding append/prepend nodes to EuiDatePicker will help with a significant amount of those use cases, as people were using the layout wrapper just for appending/prepending info to the date picker input.

QA

  • Go to https://eui.elastic.co/pr_7987/#/forms/date-picker#date-picker-inline
  • [ ] Both inline date pickers should not have a border when the Show shadow switch is toggled
Before After
  • Go to https://eui.elastic.co/pr_7987/#/forms/date-picker#date-picker-states or https://eui.elastic.co/pr_7987/storybook/?path=/story/forms-euidatepicker--playground
  • [ ] Toggling the append/prepend display should render side nodes as expected, e.g.

General checklist

  • Browser QA
    • [x] Checked in both light and dark modes
    • [x] Checked in mobile
    • [x] Checked in Chrome, Safari, Edge, and Firefox ~- [ ] Checked for accessibility including keyboard-only and screenreader modes~
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • [x] A changelog entry exists and is marked appropriately. ~- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)~
  • Designer checklist - N/A

cee-chen avatar Aug 27 '24 20:08 cee-chen

:green_heart: Build Succeeded

History

  • :green_heart: Build #2651 succeeded 4685c696a7b717e1c9dcec24c40751d5994939e3

elasticmachine avatar Aug 28 '24 15:08 elasticmachine