eui icon indicating copy to clipboard operation
eui copied to clipboard

[EUI Refresh] A weight has been lifted...

Open ryankeairns opened this issue 1 year ago • 2 comments

Summary

Setting to draft until we can check in Kibana and get the go-ahead.

Our page titles and weights - esp in modals and flyouts - are heavy and (subjective) feel rather outdated. I realize a new theme is coming, but in the spirit of making incremental improvements and not waiting months longer... I present this PR.

General checklist

  • Browser QA
    • [ ] Checked in both light and dark modes
    • [ ] Checked in mobile
    • [ ] Checked in Chrome, Safari, Edge, and Firefox
    • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • [ ] A changelog entry exists and is marked appropriately.
    • [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • [ ] If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

ryankeairns avatar Aug 02 '24 23:08 ryankeairns

:green_heart: Build Succeeded

History

  • :broken_heart: Build #2524 failed 7710de2abfca9a851d31109991d242f9873fa9c7
  • :broken_heart: Build #2523 failed f1a1ecf9c6938f7b87138f2f1607361430a8d614
  • :green_heart: Build #2513 succeeded fc6bf0d7f51741a9405784cdb886306b8e92188b

cc @ryankeairns

elasticmachine avatar Aug 07 '24 20:08 elasticmachine

I will chat with @yanwalton about the gates we need to clear to get this approved and merged.

ryankeairns avatar Aug 20 '24 23:08 ryankeairns

These changes will be integrated with phase 1 changes aimed at Kibana 9.0 release (as part of the new theme)

kyrspl avatar Sep 30 '24 14:09 kyrspl

ℹ️ We're going to implement the changes as part of this task.

mgadewoll avatar Sep 30 '24 14:09 mgadewoll

Shall I close this PR then?

ryankeairns avatar Sep 30 '24 14:09 ryankeairns

These changes will be integrated with phase 1 changes aimed at Kibana 9.0 release (as part of the new theme)

ryankeairns avatar Sep 30 '24 16:09 ryankeairns

Spinning up a new test instance so resurrected this branch

JasonStoltz avatar Oct 18 '24 16:10 JasonStoltz