eui icon indicating copy to clipboard operation
eui copied to clipboard

EuiDataGrid allow expanding rows

Open lior-fortifieddata opened this issue 3 years ago • 6 comments
trafficstars

Enhancement request:

Allow expanding rows in EuiDataGrid as in EuiTable:

https://elastic.github.io/eui/#/tabular-content/tables#expanding-rows

lior-fortifieddata avatar Aug 03 '22 14:08 lior-fortifieddata

Thanks for the issue! This has been a repeated request from some internal teams as well, and we have captured those use cases and our concerns + implementation thoughts in discussion #5638

At this time we have not committed to adding this feature, largely due to other commitments. If you would like to add details about your use case to that discussion we will certainly consider it as we continue exploring this.

chandlerprall avatar Aug 03 '22 17:08 chandlerprall

Thanks for replying! Our use case is grouping the grid by one of the columns, and then expand each raw and see it's data.

I can provide an example if needed.


From: Chandler Prall @.> Sent: Wednesday, August 3, 2022, 20:31 To: elastic/eui @.> Cc: Lior Goldemberg @.>; Author @.> Subject: Re: [elastic/eui] EuiDataGrid allow expanding rows (Issue #6101)

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

Thanks for the issue! This has been a repeated request from some internal teams as well, and we have captured those use cases and our concerns + implementation thoughts in discussion #5638https://github.com/elastic/eui/discussions/5638

At this time we have not committed to adding this feature, largely due to other commitments. If you would like to add details about your use case to that discussion we will certainly consider it as we continue exploring this.

— Reply to this email directly, view it on GitHubhttps://github.com/elastic/eui/issues/6101#issuecomment-1204267021, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOIHQW73KXX6QINWPTJZBULVXKUIVANCNFSM55PE2S5A. You are receiving this because you authored the thread.Message ID: @.***>

lior-fortifieddata avatar Aug 03 '22 18:08 lior-fortifieddata

@chandlerprall May I ask if the MOV files inside the issue you have attached, are design system output or live code?

lior-fortifieddata avatar Aug 03 '22 20:08 lior-fortifieddata

Our use case is grouping the grid by one of the columns, and then expand each raw and see it's data.

We also have issue #4636 for groups/summary rows; at the technical level that and a full row expansion would both likely require some kind of rowspan/colspan implementation. (there's at least some disagreement with this statement as row expansion could be implemented just fine in other ways)

May I ask if the MOV files inside the issue you have attached, are design system output or live code?

Those are from live code running in Kibana's security app. That team relies heavily on the row renderer concept for expanding data into a visualization, corresponding to the type of security event. Because we do not have this capability in datagrid, they have spent a lot of time implementing (and documenting in that discussion) their UX & accessibility work.

chandlerprall avatar Aug 03 '22 20:08 chandlerprall

Thanks a lot. I've tried to find that in Kibana's code, and it look like it uses "TgridTdCell" to render it. (not sure I'm in the right place)

https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/public/timelines/components/timeline/body/data_driven_columns/index.tsx

lior-fortifieddata avatar Aug 04 '22 09:08 lior-fortifieddata

You're in the right place, or at least the general area. To be honest I'm not real familiar with that implementation, but if we do start working on row renderers / cell merging in EuiDataGrid we'll use that code as one of the references.

chandlerprall avatar Aug 09 '22 18:08 chandlerprall

👋 This issue hasn't seen activity in 3 days, so we're automatically closing this issue as answered. Please leave a comment if that's not the case, or if you have any remaining questions or issues.

github-actions[bot] avatar Aug 13 '22 00:08 github-actions[bot]

Hi, I was wondering if there is any update on this request?

qutayba avatar Jan 22 '24 11:01 qutayba