eui icon indicating copy to clipboard operation
eui copied to clipboard

Published 20 hours ago • verified publisher icon elastic

[EuiOverlayMask] Convert to Emotion; remove `onClick` prop

Open thompsongl opened this issue 3 years ago • 4 comments

Summary

Like it says on the tin.

Also,

  • Closes #6016 by removing onClick
  • Uses EuiPortal because the portaling code is nearly identical
  • Uses Global styling because React cannot act on the DOM-created element

Checklist

  • [x] Checked in both light and dark modes
  • [x] Checked in mobile
  • [x] Checked in Chrome, Safari, Edge, and Firefox
  • [x] Props have proper autodocs and playground toggles
  • [x] Checked Code Sandbox works for any docs examples
  • [x] Added or updated jest and cypress tests
  • [x] Checked for breaking changes and labeled appropriately
  • [x] Checked for accessibility including keyboard-only and screenreader modes
  • [x] A changelog entry exists and is marked appropriately

thompsongl avatar Jul 28 '22 19:07 thompsongl

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

kibanamachine avatar Jul 28 '22 19:07 kibanamachine

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

kibanamachine avatar Aug 01 '22 17:08 kibanamachine

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

kibanamachine avatar Aug 01 '22 18:08 kibanamachine

Setting back to draft until EuiPortal changes are settled

thompsongl avatar Aug 04 '22 14:08 thompsongl

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

kibanamachine avatar Aug 22 '22 20:08 kibanamachine

Hmm now belowHeader isn't working

thompsongl avatar Aug 29 '22 20:08 thompsongl

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

kibanamachine avatar Aug 29 '22 20:08 kibanamachine

Ready again, @chandlerprall

thompsongl avatar Aug 30 '22 15:08 thompsongl

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

kibanamachine avatar Aug 30 '22 16:08 kibanamachine

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

kibanamachine avatar Aug 30 '22 18:08 kibanamachine

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

kibanamachine avatar Aug 30 '22 22:08 kibanamachine