eui icon indicating copy to clipboard operation
eui copied to clipboard

Consider splitting out TS files

Open mmahalwy opened this issue 3 years ago • 4 comments
trafficstars

At the moment, the TS definition file is about 22k lines. Makes it difficult on VS Code performance. Thoughts on splitting up the definition files? Should be an easy tsconfig.json change

mmahalwy avatar Dec 16 '21 18:12 mmahalwy

Yes, this would be nice! I think any effort on this would best coincide with our broader modularization effort and likely monorepo setup (which we need to do a better job of defining 😅). I'll mark this as a long-term goal and will tag in a forthcoming modularization issue. If there is some kind of immediate change that makes sense in the meantime, we can evaluate.

thompsongl avatar Dec 16 '21 22:12 thompsongl

i can look into making this change. I noticed you're using https://www.npmjs.com/package/dts-generator which hasn't been updated in over 3 years and I think TS now supports outputting a single .d.ts file natively.

mmahalwy avatar Dec 16 '21 22:12 mmahalwy

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

github-actions[bot] avatar Jun 15 '22 00:06 github-actions[bot]

Smaller/individual TS files will likely be a natural result of the work in #5540. Each package (at a minimum) will have its own file, if not each component.

thompsongl avatar Jun 15 '22 14:06 thompsongl

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

github-actions[bot] avatar Dec 13 '22 00:12 github-actions[bot]

..

mmahalwy avatar Dec 13 '22 02:12 mmahalwy

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

github-actions[bot] avatar Oct 22 '23 00:10 github-actions[bot]