eui icon indicating copy to clipboard operation
eui copied to clipboard

[EuiSideNav] ID generation isn't server-side rendering safe

Open chandlerprall opened this issue 4 years ago • 1 comments

Discovered while testing a version upgrade in the next-eui starter: https://github.com/elastic/next-eui-starter/pull/47#pullrequestreview-818091331 , the sideNavContentId value used for an id+aria-controls isn't server-side rendering safe.

Screen Shot 2021-11-29 at 11 14 23 AM

chandlerprall avatar Nov 29 '21 18:11 chandlerprall

See https://github.com/facebook/react/issues/5867 for a definition of the problem space. Thankfully, React 18 ships with a useId hook to solve - we'll need to wait until we drop support for React@17 to fix this. However, apart from being a hard to ignore warning, this id mismatch does not cause any issues.

chandlerprall avatar Feb 23 '22 22:02 chandlerprall

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

github-actions[bot] avatar Sep 22 '25 00:09 github-actions[bot]