eui icon indicating copy to clipboard operation
eui copied to clipboard

[EuiDataGrid] Selection columns are not aligned

Open cchaos opened this issue 4 years ago • 5 comments
trafficstars

I have tested the feature locally, Everything works as expected 👍
The only thing is that I found a misalignment between the header and the row checkboxes:

misalignment

@elastic/eui-design This is caused by the EuiDataGrid using gridStyle={{border: 'none'}}. The border: none; rule is applied to the header: header

but the row divs only have border-color: transparent !important;: cell

Originally posted by @semd in https://github.com/elastic/kibana/issues/107144#issuecomment-889896823

cchaos avatar Jul 30 '21 15:07 cchaos

Repro: https://codesandbox.io/s/elated-voice-uukqf?file=/index.js

cchaos avatar Jul 30 '21 16:07 cchaos

@cchaos So what do we want to keep!? alignment of row or header

hetanthakkar avatar Jul 31 '21 12:07 hetanthakkar

@hetanthakkar1 Keep the individual row's transparent borders since they're used in calculating the sizing of the cells.

cchaos avatar Aug 02 '21 18:08 cchaos

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

github-actions[bot] avatar Jan 30 '22 00:01 github-actions[bot]

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

github-actions[bot] avatar Jul 30 '22 16:07 github-actions[bot]

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

github-actions[bot] avatar Jan 28 '23 16:01 github-actions[bot]

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

github-actions[bot] avatar Feb 05 '23 00:02 github-actions[bot]