eui
eui copied to clipboard
elastic
[EuiDataGrid] Add arrow keys to popover
It would be convenient if a user could use the arrow keys to navigate between cell popovers. Currently you've to close a popover, navigate to the next cell, expand the cell to archive this. Using arrow keys would save lots of time.
If the user the user would like to navigate to has no popover, just the cell could be focused instead
Some a11y notes if anyone decides to pick this up:
- we'd need to provide some context to the next popover to open (the screen reader should read out all the same info as if the user has closed the current popover, navigated to a new cell, and then opened the following popover). Would probably need an
aria-liveregion to accomplish all this. - would need to take some care to make sure it doesn't break nested arrow controls in popovers (though maybe that's not the popovers problem and the nested components need to stop propagation?). I'm thinking about things like Comboboxes which require arrow key navigation.
@kertal a few things about this:
-
Would this involve automatically making the first cell active if the entire
EuiDataGridis focussed and an arrow key is pressed? Seems like the focussed selection might need a directional awareness if this were to be implemented. -
Also focusing on the cell should also expand it to reveal the actions, or should it just focus it and allow to move between them?
we'd need to provide some context to the next popover to open (the screen reader should read out all the same info as if the user has closed the current popover, navigated to a new cell, and then opened the following popover). Would probably need an aria-live region to accomplish all this.
@myasonik won't focusing on the cell and opening the popovers trigger the normal accessibility setting and the screen reader?
won't focusing on the cell and opening the popovers trigger the normal accessibility setting and the screen reader?
Potentially but probably depends on exactly how it's implemented it. My worry is that there won't actually be a moment that the cell is focused and focus effectively moves from popover to popover, without ever going to a cell.
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.
👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.
❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context.