eui
eui copied to clipboard
[EuiBasicTable] EuiTableFieldDataColumnType.mobileOptions type appears incomplete
Our docs for Build a custom table from individual components present a more flexible mobileOptions object than what EuiBasicTable's columns accepts; I'm not sure if this is intended. If so, we should document the difference in that section. If not, we need to widen the column mobileOptions type.
Edit: decision made, the types need to be widened to match the underlying column types
EuiTableFieldDataColumnType.mobileOptions is defined as
https://github.com/elastic/eui/blob/91badba89f4b816880ba63654adf6cf7ebaf62a5/src/components/basic_table/table_types.ts#L55-L60
Although it is a straight pass-through to EuiTableHeaderCell https://github.com/elastic/eui/blob/91badba89f4b816880ba63654adf6cf7ebaf62a5/src/components/basic_table/basic_table.tsx#L714
https://github.com/elastic/eui/blob/91badba89f4b816880ba63654adf6cf7ebaf62a5/src/components/basic_table/basic_table.tsx#L739
https://github.com/elastic/eui/blob/91badba89f4b816880ba63654adf6cf7ebaf62a5/src/components/basic_table/basic_table.tsx#L781
And also a pass through to EuiTableRowCell
https://github.com/elastic/eui/blob/91badba89f4b816880ba63654adf6cf7ebaf62a5/src/components/basic_table/basic_table.tsx#L1200-L1206
Ah I think the type is actually out of date. It should match what's in the docs.
👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.