elasticsearch-py icon indicating copy to clipboard operation
elasticsearch-py copied to clipboard

Consider using pyproject.toml replace setup.py

Open ischaojie opened this issue 2 years ago • 4 comments

Describe the feature:

pyproject.toml has become the de facto python project standard, perhaps we should replace the current setup.py with a tool such as hatch?

ischaojie avatar Feb 07 '23 04:02 ischaojie

That would be a great improvement, let's use Hatch.

sethmlarson avatar Feb 07 '23 14:02 sethmlarson

Hey, can someone help me solve this here, I am a beginner. Thanks in advance

NamanJainCG avatar Sep 17 '23 05:09 NamanJainCG

Hello, I would suggest that you read https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html and https://packaging.python.org/en/latest/tutorials/packaging-projects/ first. You will also have to remove setup.py from noxfile.py and MANIFEST.in, and adjust the code in utils/build-dists.py to change the version in pyproject.toml.

pquentin avatar Sep 18 '23 06:09 pquentin

That said, #2156 exists so I need to review it instead.

pquentin avatar Dec 08 '23 09:12 pquentin

Done in https://github.com/elastic/elasticsearch-py/pull/2600.

pquentin avatar Nov 05 '24 05:11 pquentin