elasticsearch-perl icon indicating copy to clipboard operation
elasticsearch-perl copied to clipboard

Replace Try::Tiny

Open spansh opened this issue 6 years ago • 3 comments

Addressing issue: https://github.com/elastic/elasticsearch-perl/issues/162

Replacing Try::Tiny with raw eval as it has speed issues. Also fixed a pretty=1 vs pretty=true issue in the test files.

Had some issues running the other dists, eventually worked around this via PERL5LIB=`pwd`/../lib ES=localhost:9200 dzil test and everything passed through there were some deprecation warnings.

I don't have any ES instance other than 6.5.4 at the moment so I can't test the 1 and 2 branches easily

spansh avatar Apr 01 '19 15:04 spansh

Have now signed as well

spansh avatar Apr 01 '19 15:04 spansh

Hi @spansh, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

elasticcla avatar Apr 01 '19 15:04 elasticcla

Hi @spansh, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

Done, should work now. Assuming that comment was automated you probably want to address the "yout" => "your" issue (if anyone ends up reading this).

spansh avatar Apr 01 '19 15:04 spansh

is there a particular reason you're closing this (and you closed the original issue)? The performance issues remain (Try::Tiny hasn't been fixed or even updated) and there is a huge difference in performance purely caused by using Try::Tiny especially if you're performing operations in bulk.

spansh avatar Dec 14 '23 10:12 spansh