ecs-logging-php icon indicating copy to clipboard operation
ecs-logging-php copied to clipboard

Monolog and PHP 8 updates

Open phil-nelson opened this issue 3 years ago • 3 comments

This update fixes an issue working with monolog 2.5 and above, where the IntrospectionProcessor added a callType field to its output. Since the ElasticCommonSchemaFormatter does not know about this field, it gets added as a top level key instead of within log.origin even when $useLogOriginFromContext is set. This can be demonstrated by simply checking out the main branch of this repo and running composer install && composer test.

This fixes the issue by adding callType to the list of known origin keys and also uses it (if available, so will still work with monolog < 2.5) within the log.origin.function field. E.g. MyClass::myFunction or MyClass->myFunction.

As a minor additional change it also marks compatibility with psr/log 2.x and 3.x.

phil-nelson avatar Jul 29 '22 01:07 phil-nelson

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-08T19:43:15.097+0000

  • Duration: 3 min 51 sec

Steps errors 2

Expand to view the steps failures

Load a resource file from a library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/ecs-logging-php.yml
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/phil-nelson return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/phil-nelson : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/phil-nelson : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

:robot: GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

apmmachine avatar Jul 29 '22 01:07 apmmachine

Maybe you can include diff from https://github.com/elastic/ecs-logging-php/compare/main...paveljanda:ecs-logging-php:main? (native PHP types)

paveljanda avatar Nov 11 '22 13:11 paveljanda

run docs-build

v1v avatar Feb 08 '24 09:02 v1v