ecs-logging-nodejs icon indicating copy to clipboard operation
ecs-logging-nodejs copied to clipboard

consider using `URL` for parsing in helpers.formatHttpRequest

Open trentm opened this issue 4 years ago • 0 comments

Currently formatHttpRequest is manually doing URL parsing. I think using the standard url.URL for parsing would fix potential issues with weird URLs.

Also, in the case of a hapi request object, there is an already parsed request.url available. Express request objects might have the same thing. Not sure about other frameworks (e.g. fastify).

trentm avatar Feb 08 '21 21:02 trentm