ecs-logging-nodejs icon indicating copy to clipboard operation
ecs-logging-nodejs copied to clipboard

Published 20 hours ago • verified publisher icon elastic

add support for `service.version` and `service.environment` with apmInstrumentation

Open trentm opened this issue 3 years ago • 1 comments

service.version, at least, has been added to the ecs-logging spec: https://github.com/elastic/ecs-logging/blob/d8ee4d4ba5853a10425ac21f41a5ff04f84b355b/spec/spec.json#L88-L96 with the comment that:

When an APM agent is active, it should auto-configure it if not already set.

The spec will be sync'd here with #120.

Then ecs-logging-java added support for service.version and service.environment:

  • https://github.com/elastic/ecs-logging-java/pull/168
  • https://github.com/elastic/ecs-logging-java/pull/184

Should the node.js ecs-logging libs do the same?

trentm avatar May 10 '22 20:05 trentm

This adds service.environment to the spec as well now: https://github.com/elastic/ecs-logging-nodejs/pull/123

trentm avatar May 16 '22 14:05 trentm