cloudbeat
cloudbeat copied to clipboard
fix gh artifacts upload with the latest action version
Summary of your changes
It seems that after a version update of upload-artifact something is wrong when we give a folder as a path to upload.
In our CI, we upload the produced Docker images as artifacts, which are later downloaded and used for kspm testing.
I didn't investigate the action code to find out why, but as a workaround, I changed the upload path from folder to wildcard pattern, and it works.
path: |
${{ inputs.docker-images-folder }}/*.tar
Screenshot/Data
https://github.com/elastic/cloudbeat/actions/runs/11340902754?pr=2605
Related Issues
Checklist
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added the necessary README/documentation (if appropriate)
Introducing a new rule?
- [ ] Generate rule metadata using this script
- [ ] Add relevant unit tests
- [ ] Generate relevant rule templates using this script, and open a PR in elastic/packages/cloud_security_posture
:bar_chart: Allure Report - :green_heart: No failures were reported.
| Result | Count |
|---|---|
| 🟥 Failed | 0 |
| 🟩 Passed | 216 |
| ⬜ Skipped | 33 |
@oren-zohar because currently the 8.15 ci breaks because of that
@moukoublen With the last push 4 months ago, is this still pertinent, or can we close?
This pull request is now in conflicts. Could you fix it? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/
git fetch upstream
git checkout -b fix_gh_artifacts_upload upstream/fix_gh_artifacts_upload
git merge upstream/main
git push upstream fix_gh_artifacts_upload