beats icon indicating copy to clipboard operation
beats copied to clipboard

buildkite: change github comments

Open v1v opened this issue 1 year ago • 9 comments

Proposed commit message

  • WHAT: Simplify the GitHub comment for running the Buildkite pipeline.
  • WHY: This pipeline is not currently used, and it was created as a placeholder. This will help with https://github.com/elastic/beats/pull/38162 temporarily, then it could be changed again.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

I used https://regex101.com/ for verifying the regex:

image

Related issues

Use cases

Screenshots

Logs

v1v avatar Mar 04 '24 16:03 v1v

This pull request doesn't have a Team:<team> label.

botelastic[bot] avatar Mar 04 '24 16:03 botelastic[bot]

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @v1v? 🙏. For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

mergify[bot] avatar Mar 04 '24 16:03 mergify[bot]

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 13 min 11 sec

:grey_exclamation: Flaky test report

No test was executed to be analysed.

:robot: GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine avatar Mar 04 '24 16:03 elasticmachine

:green_heart: Build Succeeded

cc @v1v

elasticmachine avatar Mar 04 '24 16:03 elasticmachine

:green_heart: Build Succeeded

cc @v1v

elasticmachine avatar Mar 04 '24 16:03 elasticmachine

:green_heart: Build Succeeded

cc @v1v

elasticmachine avatar Mar 04 '24 16:03 elasticmachine

:green_heart: Build Succeeded

cc @v1v

elasticmachine avatar Mar 04 '24 17:03 elasticmachine

:green_heart: Build Succeeded

cc @v1v

elasticmachine avatar Mar 04 '24 17:03 elasticmachine

:green_heart: Build Succeeded

cc @v1v

elasticmachine avatar Mar 04 '24 17:03 elasticmachine

@alexsapran This older open PR looks very similar to your fix from https://github.com/elastic/beats/pull/38487

rowlandgeoff avatar Mar 21 '24 03:03 rowlandgeoff

@alexsapran This older open PR looks very similar to your fix from https://github.com/elastic/beats/pull/38487

Indeed, https://github.com/elastic/beats/pull/38487 might have some side effects while Jenkins is still the CI.

This PR was intended to leverage the existing proposal in https://github.com/elastic/beats/pull/38162 without running twice (builds in Jenkins and Buildkite) during the migration. That's the reason I used the building prefix rather than /test

v1v avatar Mar 21 '24 08:03 v1v

What type of side effects you are thinking of? other than the fact that it will trigger both?

It's something that I wanted to have, so I can test that both implementations are doing what we want them to do, this is how I discovered for example an issue with how we select some pipeline steps, by checking the Jenkins and Buildkite steps.

alexsapran avatar Mar 21 '24 09:03 alexsapran

What type of side effects you are thinking of? other than the fact that it will trigger both?

That's the only thing.

It's something that I wanted to have, so I can test that both implementations are doing what we want them to do, this is how I discovered for example an issue with how we select some pipeline steps, by checking the Jenkins and Buildkite steps.

Then forget please what I said, I didn't have that context. Sorry for the noise 🙏

v1v avatar Mar 21 '24 10:03 v1v

I'll close this now as duplicates the other one

v1v avatar Mar 21 '24 10:03 v1v

Then forget please what I said, I didn't have that context. Sorry for the noise 🙏

Better safe than sorry, thanks for keeping an eye and for asking questions.

alexsapran avatar Mar 21 '24 10:03 alexsapran