apm icon indicating copy to clipboard operation
apm copied to clipboard

Published 20 hours ago • verified publisher icon elastic

Make `include_process_args` an opt-in option

Open AlexanderWert opened this issue 2 years ago • 3 comments
trafficstars

Description

Make include_process_args an opt-in option

Spec Issue

  • [ ] https://github.com/elastic/apm/issues/809 Milestone

Agent Issues

  • [ ] https://github.com/elastic/apm-agent-dotnet/issues/2120 Milestone
  • [ ] https://github.com/elastic/apm-agent-nodejs/issues/3444 Milestone
  • [ ] https://github.com/elastic/apm-agent-python/issues/1860 Milestone
  • [ ] https://github.com/elastic/apm-agent-php/issues/1004 Milestone

AlexanderWert avatar Jun 26 '23 09:06 AlexanderWert

Does this include adding the option if we don't already support it? Python doesn't have include_process_args.

basepi avatar Jun 26 '23 18:06 basepi

Does this include adding the option if we don't already support it? Python doesn't have include_process_args.

Yes, if the option is missing, then it should be added as part of this effort.

AlexanderWert avatar Jun 27 '23 05:06 AlexanderWert

We should perhaps also:

  • [ ] Update https://github.com/elastic/apm-server/blob/main/docs/apm-data-security.asciidoc#agent-specific-options when agents add this config option.

Aside: A thing that confused me for a short while: In the intake API it is metadata.process.argv. At some point that becomes process.args (s instead of v) in the Elasticsearch document. (It doesn't matter, but I'm not sure exactly where that transformation is done.)

trentm avatar Jun 29 '23 16:06 trentm