apm icon indicating copy to clipboard operation
apm copied to clipboard

[OpenTelemetry] Metrics derived from traces (Throughput, Latency and Errors) are not accurate when traces are sampled before being ingested by Elastic Observability

Open cyrille-leclerc opened this issue 4 years ago • 5 comments

Enhancement Description

Metrics derived from traces (Throughput, Latency and Errors) are not accurate when traces are sampled before being ingested by Elastic Observability (ie by an OpenTelemetry Collector or OpenTelemetry APM agent or SDK).

@axw : "This is because there's no record of the sampling rate in span data; we would need open-telemetry/oteps#148 for this."

2021/11/18 OpenTelemetry specified how to propagate sampling data

cyrille-leclerc avatar Jul 19 '21 07:07 cyrille-leclerc

@cyrille-leclerc is there an update on this one? It looks like there's been merge activity related to the dependent otep in the last month or two. Thanks

tiny-dancer avatar Nov 18 '21 11:11 tiny-dancer

@tiny-dancer the proposal has been merged, but that's only the start of its journey. It still needs to be debated & accepted, converted to a specification, and then implemented. When all of those things have happened, we should be able to close this out.

axw avatar Nov 19 '21 03:11 axw

Ah thank you for the clarification. One step down!

tiny-dancer avatar Nov 19 '21 04:11 tiny-dancer

Is there any workaround for when the sampling rate is 100%?

MoshiBin avatar Jul 21 '22 12:07 MoshiBin

@MoshiBin if the sampling rate is 100%, then the metrics should be accurate. This issue is only relevant when sampling < 100%.

axw avatar Jul 21 '22 12:07 axw