apm-server
apm-server copied to clipboard
[Intake] `http.request.id`
I'd like to add request.id to span.context.http in the intake.
This comes from a user request to store the AWS Request ID in span context, which I think is very reasonable. http.request.id seems to be the closest fit in ECS.
Questions/thoughts welcome.
An alternative would be to use span.context.response.headers if this isn't considered a wide enough use-case to add to the intake.
Adding request.id sounds reasonable! Thanks for opening the issue.
@basepi @AlexanderWert @estolfo The scope of this issue is limited to span but I'm wondering if we want the same ID field under error.context.request and transaction.context.request. If there is no use case then we can stick with just span.
@carsonip Right now the only case in which I see some value of transaction.context.request.id would be for AWS Lambda transactions. BUT: we already capture the request ID for lambda under faas.execution, so no need to duplicate this information.
For error.context.request.id we would need to propagate the request ID to be able to attach it to errors (what we currently don't and cannot do because of missing baggage support).
So I would propose to only have it for span.context.request.id for now.