apm-server icon indicating copy to clipboard operation
apm-server copied to clipboard

[apm docs consolidation] 8.7: Delete moved files, update README

Open colleenmcginnis opened this issue 1 year ago • 6 comments

Related to https://github.com/elastic/apm-server/pull/12341

colleenmcginnis avatar Jan 04 '24 16:01 colleenmcginnis

@elasticmachine, run elasticsearch-ci/docs

colleenmcginnis avatar Jan 12 '24 17:01 colleenmcginnis

The docs build passed. 🤷‍♀️ I'm not familiar with the failing checks.

colleenmcginnis avatar Jan 12 '24 19:01 colleenmcginnis

diff --git a/NOTICE.txt b/NOTICE.txt
index 30c9e6c0c..51405e382 100644
--- a/NOTICE.txt
+++ b/NOTICE.txt
@@ -1,5 +1,5 @@
 Elastic APM Server
-Copyright 2014-2023 Elasticsearch BV
+Copyright 2014-2024 Elasticsearch BV
 
 This product includes software developed by The Apache Software 
 Foundation (http://www.apache.org/).

8.8 backport PR https://github.com/elastic/apm-server/pull/12358 is passing CI because there's a shortcut for docs to bypass the lint check #10564 . We either 1. fix the year in NOTICE.txt for all old branches like we did in #12333; or 2. update CI to bypass the check for docs PRs. I like the latter better.

carsonip avatar Jan 15 '24 14:01 carsonip

CI because there's a shortcut for docs to bypass the lint check

actually, the same bypass exists for 8.7 branch, but because there are .yml files deleted in the PR, it triggers the lint job instead of bypassing it.

carsonip avatar Jan 15 '24 14:01 carsonip

Is it worth doing that for all of these branches? Or can we just merge this because these are the last docs PRs that will ever go into these branches?

Edit: I'm going to update the notice.txt

bmorelli25 avatar Jan 16 '24 19:01 bmorelli25

run docs-build

v1v avatar Feb 09 '24 08:02 v1v

I don't believe it's worth the effort. I'll close this.

If you disagree, feel free to reopen this and we can discuss with the robots team what to do

kruskall avatar Jun 12 '24 17:06 kruskall