apm-agent-rum-js icon indicating copy to clipboard operation
apm-agent-rum-js copied to clipboard

Missing `block` method in type declaration

Open ldgrp opened this issue 2 years ago • 2 comments

The API reference documents the existence of transaction.block https://www.elastic.co/guide/en/apm/agent/rum-js/current/transaction-api.html#transaction-block

It appears to be a public method of Transaction here https://github.com/elastic/apm-agent-rum-js/blob/bf7690e69130978c9782a1adc51647f5c77f781a/packages/rum-core/src/performance-monitoring/transaction.js#L157

But is not included in the type declaration https://github.com/elastic/apm-agent-rum-js/blob/bf7690e69130978c9782a1adc51647f5c77f781a/packages/rum/src/index.d.ts#L30-L53

ldgrp avatar Mar 31 '23 04:03 ldgrp

I think this might be related https://github.com/elastic/apm-agent-rum-js/issues/1267

ldgrp avatar Mar 31 '23 04:03 ldgrp

Hi @ldgrp,

Thanks for pointing it out, much appreciated

For the time being, if the missing type declaration is causing you any issues you could apply the workaround described here

Cheers, Alberto

devcorpio avatar Mar 31 '23 08:03 devcorpio