apm-agent-nodejs icon indicating copy to clipboard operation
apm-agent-nodejs copied to clipboard

async-cache is deprecated

Open fgblomqvist opened this issue 3 years ago • 6 comments

Describe the bug

Installing this package yields a message that [email protected] is deprecated, along with what to replace it with (lru-cache).

To Reproduce

Steps to reproduce the behavior:

  1. Install the package.
  2. See above mentioned message.

(Or just run npm audit).

Expected behavior

Should not be relying on deprecated packages.

fgblomqvist avatar Apr 13 '22 09:04 fgblomqvist

Thanks. We'll update to lru-cache as soon as we are able.

trentm avatar Apr 26 '22 16:04 trentm

If it helps readers, async-cache isn't broken and doesn't have any security issues. It is just that the author moved the functionality to lru-cache. Unfortunately that version of lru-cache dropped support for node v8 and v10, which elastic-apm-node 3.x still supports, so this will have to wait until we drop support for node v8 and v10.

trentm avatar Jul 25 '22 22:07 trentm

V8 has already been EOL for 3 years, and in April V10 will be EOL for 2. What is the vision regarding this? When will support be dropped?

For me it feels strange to let these kinds of stories sit around to support 'ancient' technology. Why not just drop support, and if users are still on V8 or V10, they can just install an older version of the dependency right?

mats-stijlaart avatar Feb 02 '23 12:02 mats-stijlaart

@mats-stijlaart Thanks. We will at some point, it just hasn't been a priority yet because (a) I'm not aware of the this warning actually breaking anything or anyone, and (b) while the continued v8 and v10 support in this repo is a slight maintenance burden, it hasn't yet felt so much of a burden that it stymies development.

trentm avatar Feb 02 '23 17:02 trentm

Bump. Getting this warning in v3.47.0.

jmrnilsson avatar Aug 24 '23 06:08 jmrnilsson

@jmrnilsson We are working on an elastic-apm-node@4 to be released soonish. We'll be able to drop async-cache (in favour of lru-cache) then.

trentm avatar Aug 29 '23 19:08 trentm