apm-agent-nodejs
apm-agent-nodejs copied to clipboard
elastic
Move rss metric from `system.process.memory.*` to `nodejs.memory.*`
This PR was created based on the changes of #1724.
I've renamed the metric system.process.memory.rss.bytes to nodejs.memory.rss.bytes because the value is fetched from within nodejs, not from the system.
This is a backwards incompatible change, which I originally wanted to include in elastic/apm-agent-nodejs#1724 but created it in a separate PR because it changes an existing metric.
It makes the naming of metrics consistent. All memory related metrics, taken from within the application, are now organised in nodejs.memory.*.
Checklist
- [x] Implement code
- [x] Add tests
- [x] Update documentation
- [x] Commit message follows commit guidelines
:broken_heart: Build Failed
Expand to view the summary
Build stats
-
Build Cause: [Branch indexing]
-
Start Time: 2020-05-04T18:22:24.291+0000
-
Duration: 3 min 26 sec (206288)
-
Commit: 57915c55084a872a919a882cbd058228e2751aff
Steps errors
Expand to view the steps failures
- Name: Error signal
-
Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permission
-
Result: FAILURE
-
Duration: 0 min 0 sec<
-
Start Time: 2020-05-04T18:25:44.086+0000
-
Log output
Expand to view the last 100 lines of log output
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/882/head -> origin/pr/882
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/883/head -> origin/pr/883
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/884/head -> origin/pr/884
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/885/head -> origin/pr/885
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/886/head -> origin/pr/886
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/889/head -> origin/pr/889
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/891/head -> origin/pr/891
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/893/head -> origin/pr/893
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/894/head -> origin/pr/894
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/895/head -> origin/pr/895
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/898/head -> origin/pr/898
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/9/head -> origin/pr/9
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/901/head -> origin/pr/901
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/903/head -> origin/pr/903
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/905/head -> origin/pr/905
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/906/head -> origin/pr/906
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/907/head -> origin/pr/907
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/908/head -> origin/pr/908
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/912/head -> origin/pr/912
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/914/head -> origin/pr/914
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/915/head -> origin/pr/915
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/918/head -> origin/pr/918
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/919/head -> origin/pr/919
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/92/head -> origin/pr/92
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/920/head -> origin/pr/920
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/921/head -> origin/pr/921
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/922/head -> origin/pr/922
[2020-05-04T18:25:38.556Z] * [new ref] refs/pull/923/head -> origin/pr/923
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/924/head -> origin/pr/924
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/926/head -> origin/pr/926
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/928/head -> origin/pr/928
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/93/head -> origin/pr/93
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/930/head -> origin/pr/930
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/931/head -> origin/pr/931
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/933/head -> origin/pr/933
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/934/head -> origin/pr/934
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/936/head -> origin/pr/936
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/937/head -> origin/pr/937
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/938/head -> origin/pr/938
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/939/head -> origin/pr/939
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/942/head -> origin/pr/942
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/943/head -> origin/pr/943
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/944/head -> origin/pr/944
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/946/head -> origin/pr/946
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/947/head -> origin/pr/947
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/949/head -> origin/pr/949
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/95/head -> origin/pr/95
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/952/head -> origin/pr/952
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/954/head -> origin/pr/954
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/956/head -> origin/pr/956
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/957/head -> origin/pr/957
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/958/head -> origin/pr/958
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/96/head -> origin/pr/96
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/965/head -> origin/pr/965
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/966/head -> origin/pr/966
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/967/head -> origin/pr/967
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/969/head -> origin/pr/969
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/97/head -> origin/pr/97
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/972/head -> origin/pr/972
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/974/head -> origin/pr/974
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/975/head -> origin/pr/975
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/98/head -> origin/pr/98
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/980/head -> origin/pr/980
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/981/head -> origin/pr/981
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/982/head -> origin/pr/982
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/983/head -> origin/pr/983
[2020-05-04T18:25:38.557Z] * [new ref] refs/pull/985/head -> origin/pr/985
[2020-05-04T18:25:38.564Z] * [new ref] refs/pull/995/head -> origin/pr/995
[2020-05-04T18:25:38.564Z] * [new ref] refs/pull/998/head -> origin/pr/998
[2020-05-04T18:25:38.564Z] * [new ref] refs/pull/999/head -> origin/pr/999
[2020-05-04T18:25:39.387Z] + git rev-parse HEAD
[2020-05-04T18:25:40.023Z] + git rev-parse HEAD
[2020-05-04T18:25:40.338Z] + git rev-parse origin/pr/1725
[2020-05-04T18:25:40.438Z] [INFO] githubEnv: Found Git Build Cause: pr
[2020-05-04T18:25:41.518Z] Masking supported pattern matches of $GITHUB_TOKEN
[2020-05-04T18:25:43.180Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/apm-agent-nodejs/pulls/1725/reviews return 0 elements
[2020-05-04T18:25:43.381Z] [INFO] githubPrCheckApproved: Title: Move rss metric from `system.process.memory.*` to `nodejs.memory.*` - User: SimonSimCity - Author Association: FIRST_TIME_CONTRIBUTOR
[2020-05-04T18:25:45.423Z] Stage "Test" skipped due to earlier failure(s)
[2020-05-04T18:25:45.499Z] Stage "TAV Test" skipped due to earlier failure(s)
[2020-05-04T18:25:45.565Z] Stage "Edge Test" skipped due to earlier failure(s)
[2020-05-04T18:25:45.992Z] Stage "Nightly Test" skipped due to earlier failure(s)
[2020-05-04T18:25:45.994Z] Stage "Nightly Test - No async hooks" skipped due to earlier failure(s)
[2020-05-04T18:25:45.995Z] Stage "RC Test" skipped due to earlier failure(s)
[2020-05-04T18:25:45.996Z] Stage "RC Test - No async hooks" skipped due to earlier failure(s)
[2020-05-04T18:25:46.141Z] Failed in branch Nightly Test
[2020-05-04T18:25:46.142Z] Failed in branch Nightly Test - No async hooks
[2020-05-04T18:25:46.143Z] Failed in branch RC Test
[2020-05-04T18:25:46.144Z] Failed in branch RC Test - No async hooks
[2020-05-04T18:25:46.594Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2020-05-04T18:25:47.059Z] Stage "Release" skipped due to earlier failure(s)
[2020-05-04T18:25:47.165Z] Stage "Release" skipped due to earlier failure(s)
[2020-05-04T18:25:47.341Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2020-05-04T18:25:48.295Z] Running on Jenkins in /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-1725
[2020-05-04T18:25:49.389Z] [INFO] getVaultSecret: Getting secrets
[2020-05-04T18:25:49.550Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-05-04T18:25:50.881Z] + chmod 755 generate-build-data.sh
[2020-05-04T18:25:50.881Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-1725/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-1725/runs/2 FAILURE 206288
[2020-05-04T18:25:51.431Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-1725/runs/2/steps/?limit=10000 -o steps-info.json
[2020-05-04T18:25:52.830Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-1725/runs/2/tests/?status=FAILED -o tests-errors.json
[2020-05-04T18:25:52.830Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-1725/runs/2/log/ -o pipeline-log.txt
