frontend-maven-plugin icon indicating copy to clipboard operation
frontend-maven-plugin copied to clipboard

Published 20 hours ago • verified publisher icon eirslett

Fix issues for pnpm

Open luangong opened this issue 3 years ago • 1 comments
trafficstars

Summary

This commit fixes the following issues for pnpm:

  • Comment mismatch.
  • pnpm is never "provided" by Node.js so <pnpmVersion> is required.
  • Java class name CamelCase: PNPMInstaller -> PnpmInstaller.

Tests and Documentation

Although pnpm support was added in https://github.com/eirslett/frontend-maven-plugin/pull/927, documentation is lacking in README.md and the project wiki. I will add documentation in a follow-up pull request.

luangong avatar May 18 '22 09:05 luangong

@eirslett Can you please take a look? Thanks!

luangong avatar Sep 09 '22 18:09 luangong

@eirslett Please take a look. Thanks!

luangong avatar Oct 01 '22 16:10 luangong

LGTM!

eirslett avatar Oct 02 '22 18:10 eirslett