dotnet-bundle icon indicating copy to clipboard operation
dotnet-bundle copied to clipboard

Should use CFBundleName instead of CFDisplayBundleName for .app name

Open LuKePicci opened this issue 4 years ago • 4 comments

I think this should use CFBundleName to determine output .app name, not CFBundleDisplayName

https://github.com/egramtel/dotnet-bundle/blob/7e681e61b259222e4e5269a1423f92e7b4649d2d/DotNet.Bundle/StructureBuilder.cs#L18

LuKePicci avatar Mar 23 '21 10:03 LuKePicci

Why? Is there any reason CFBundleName is better?

https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundlename

https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundledisplayname

x2bool avatar Apr 02 '21 16:04 x2bool

Because that is what I read on https://github.com/egramtel/dotnet-bundle/blob/master/README.md:

<CFBundleName>AppName</CFBundleName> <!-- Also defines .app file name --> <CFBundleDisplayName>App Name</CFBundleDisplayName> <CFBundleIdentifier>com.example</CFBundleIdentifier> ...

And that is what Xcode does (and Visual Studio for Mac as well on Xamarin project templates)

LuKePicci avatar Apr 02 '21 16:04 LuKePicci

Actually it could be even better to have a separate option for setting bundle filename so I can avoid renaming my system extension bundles (which are required to have a filename matching their bundle identifier with .systemextension filename extension).

LuKePicci avatar Apr 02 '21 16:04 LuKePicci

Yes, I think we could go with custom property and fallback to CFBundleName if it's not set.

x2bool avatar Apr 02 '21 17:04 x2bool