docute icon indicating copy to clipboard operation
docute copied to clipboard

Published 20 hours ago • verified publisher icon egoist

embeds

Open janat08 opened this issue 6 years ago • 10 comments

fix #205 I added this into core plugins, and made a separate page in guides for docs.

It doesn't parse titles into sidebar since you'd have to sort out the order in which they should come, which the documentation will note as much. The controls for video/audio is a boolean attribute therefore it can't be overridden with additional attributes like controls='false', and it is set on by default.

janat08 avatar Jun 17 '19 12:06 janat08

Please merge and reward

janat08 avatar Nov 18 '19 19:11 janat08

@egoist?

janat08 avatar Dec 06 '19 06:12 janat08

@egoist

janat08 avatar Dec 26 '19 05:12 janat08

@egoist wouldn't mind just the bounty, pr review whenever you feel like it. Its been half a year.

janat08 avatar Feb 12 '20 08:02 janat08

Actually we only need to use embed to inline external code, for iframe audio you can directly write HTML. See https://github.com/egoist/docute/issues/205#issuecomment-475793496

egoist avatar Mar 24 '20 08:03 egoist

Updated, please reward money at very long last.

janat08 avatar May 30 '20 14:05 janat08

I can't at all tell whats up with the circleci, as it loads a loader with null>null>null for the workflow. I'll go fix another PR to see if youll deign to reward me with that one.

janat08 avatar May 30 '20 14:05 janat08

So the circleCI is giving crap during linting that has nothing to do with my code, and doesn't even show up on local machine.

janat08 avatar May 30 '20 16:05 janat08

?

janat08 avatar Jun 09 '20 13:06 janat08

?

janat08 avatar Jun 23 '20 09:06 janat08