eggsampler
Support draft-ietf-acme-ari-03
I've updated all draft-ietf-acme-ari-01 code with the latest version, draft-ietf-acme-ari-03. Big thanks to @beautifulentropy for this blog post which made the work very easy.
Thanks for the pull request! I might not be able to review and pull this in until the weekend, if there is no immediate urgency.
That's ok, Aaron made a good point, I still have more work to do.
On Wed, May 1, 2024, 5:33 AM Isaac Truscott @.***> wrote:
Thanks for the pull request! I might not be able to review and pull this in until the weekend, if there is no immediate urgency.
— Reply to this email directly, view it on GitHub https://github.com/eggsampler/acme/pull/23#issuecomment-2088209765, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASFVZJWLXYSONDDWKPZ5ETZACZE3AVCNFSM6AAAAABHA4UJY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYGIYDSNZWGU . You are receiving this because you authored the thread.Message ID: @.***>
I've made a few updates which I think streamline the code a bit more. Specifically around streamlining the order process which removes the need for the postNewOrder function, and not making any changes to existing published function signatures.
Have run a few tests against boulder and looks good from my end, but I have not been following the updates in the ARI space. If you get a chance in the next few days would appreciate a quick eye over before I merge and bump the version.
Thank you for the contribution, help and time!
Merge it when ready :)
On Mon, May 6, 2024, 8:22 PM Isaac Truscott @.***> wrote:
@.**** approved this pull request.
Looks good to me too, thankyou!
— Reply to this email directly, view it on GitHub https://github.com/eggsampler/acme/pull/23#pullrequestreview-2041862776, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASFVZK2IZRECSLYK2IE62DZBANGBAVCNFSM6AAAAABHA4UJY6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBRHA3DENZXGY . You are receiving this because you were mentioned.Message ID: @.***>